Merge r1737114 from trunk:

Fix bug 58528 - Do not read .htaccess if override and overridelist are "None"

Submitted by: druggeri
Reviewed by: druggeri, ylavic, wrowe

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1737366 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/CHANGES b/CHANGES
index 964139f1274b6cab8058f34691965e71a586de7e..7be55d6cfacf15f3bf95c32a85095a596a6f4bfb 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -2,6 +2,10 @@
 
 Changes with Apache 2.4.20
 
+  *) core: Do not read .htaccess if AllowOverride and AllowOverrideList
+     are "None". PR 58528.
+     [Michael Schlenker <msc contact.de, Ruediger Plum, Daniel Ruggeri]
+
   *) mod_proxy_express: Fix possible use of DB handle after close.  PR 59230.
      [Petr <pgajdos suse.cz>]
      

diff --git a/STATUS b/STATUS
index 987a2ddd947e0271822d6853b7bb5d7b300b9572..2c494dd8bd4dcc78aa14764426a302805e7fdd5a 100644 (file)
--- a/STATUS
+++ b/STATUS
@@ -113,13 +113,6 @@ RELEASE SHOWSTOPPERS:
 PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
   [ start all new proposals below, under PATCHES PROPOSED. ]
 
-  *) core: Do not read .htaccess if AllowOverride and AllowOverrideList
-     are "None". PR 58528.
-     trunk patch: http://svn.apache.org/r1737114
-     2.4.x patch: http://people.apache.org/~druggeri/patches/2.4.x.AllowOverrideListFix.PR58528.patch
-     +1: druggeri, ylavic, wrowe
-     ylavic: please also apply r1737148 on merge to fix the typo on "Ruediger" (CHANGES entry)
-
 
 PATCHES PROPOSED TO BACKPORT FROM TRUNK:
   [ New proposals should be added at the end of the list ]

diff --git a/server/request.c b/server/request.c
index f8a45d0b941de782e3b740ab0d4485b7c3fc6644..eecc0266b15a99b7e5fbd73f26a8e084e7e9aa6a 100644 (file)
--- a/server/request.c
+++ b/server/request.c
@@ -1005,7 +1005,9 @@ AP_DECLARE(int) ap_directory_walk(request_rec *r)
                 /* No htaccess in an incomplete root path,
                  * nor if it's disabled
                  */
-                if (seg < startseg || (!opts.override && opts.override_list == NULL)) {
+                if (seg < startseg || (!opts.override 
+                    && apr_is_empty_table(opts.override_list)
+                    )) {
                     break;
                 }