A Py_DECREF(f) is missing in PyFrame_New for the error case when

the `builtins' initialization fails.  Vladimir Marangozov.

diff --git a/Objects/frameobject.c b/Objects/frameobject.c
index 5d854455fd0fa2f56aff2e343dc563f6d39cdf9c..64fc52feb984dcb9d6a0a96fa5b01cdc93740fd2 100644 (file)
--- a/Objects/frameobject.c
+++ b/Objects/frameobject.c
@@ -204,11 +204,11 @@ PyFrame_New(tstate, code, globals, locals)
        if (builtins == NULL) {
                /* No builtins!  Make up a minimal one. */
                builtins = PyDict_New();
-               if (builtins == NULL)
-                       return NULL;
-               /* Give them 'None', at least. */
-               if (PyDict_SetItemString(builtins, "None", Py_None) < 0)
+               if (builtins == NULL || /* Give them 'None', at least. */
+                   PyDict_SetItemString(builtins, "None", Py_None) < 0) {
+                       Py_DECREF(f);
                        return NULL;
+               }
        }
        else
                Py_XINCREF(builtins);