]> granicus.if.org Git - python/commitdiff
asyncio: Fix pyflakes warnings: remove unused variables and imports
authorVictor Stinner <victor.stinner@gmail.com>
Wed, 26 Feb 2014 10:07:42 +0000 (11:07 +0100)
committerVictor Stinner <victor.stinner@gmail.com>
Wed, 26 Feb 2014 10:07:42 +0000 (11:07 +0100)
Lib/asyncio/test_utils.py
Lib/test/test_asyncio/test_base_events.py
Lib/test/test_asyncio/test_events.py
Lib/test/test_asyncio/test_selector_events.py
Lib/test/test_asyncio/test_streams.py
Lib/test/test_asyncio/test_tasks.py
Lib/test/test_asyncio/test_unix_events.py
Lib/test/test_asyncio/test_windows_events.py

index 9a9a10b4bd08dc1e8eaa0a32049ccbe939552a3e..71d309b02cef0f4a48cbc5c581f62e6816adc1d8 100644 (file)
@@ -11,7 +11,6 @@ import sys
 import tempfile
 import threading
 import time
-import unittest
 from unittest import mock
 
 from http.server import HTTPServer
index f7a4e3a0a89e74946afe09b3873f1b77da4b248c..340ca67d64fa91d7643769b099a835aea231ad95 100644 (file)
@@ -7,7 +7,7 @@ import sys
 import time
 import unittest
 from unittest import mock
-from test.support import find_unused_port, IPV6_ENABLED
+from test.support import IPV6_ENABLED
 
 import asyncio
 from asyncio import base_events
index 055a2aaa2a430ba2bb1075461263059fa30293ed..ab58cb53c6a63597a19af5f442bf63d2f960e84b 100644 (file)
@@ -25,7 +25,6 @@ from test import support  # find_unused_port, IPV6_ENABLED, TEST_HOME_DIR
 
 
 import asyncio
-from asyncio import events
 from asyncio import selector_events
 from asyncio import test_utils
 
@@ -1648,13 +1647,12 @@ class SubprocessTestsMixin:
 
     def test_subprocess_wait_no_same_group(self):
         proto = None
-        transp = None
 
         @asyncio.coroutine
         def connect():
             nonlocal proto
             # start the new process in a new session
-            transp, proto = yield from self.loop.subprocess_shell(
+            _, proto = yield from self.loop.subprocess_shell(
                 functools.partial(MySubprocessProtocol, self.loop),
                 'exit 7', stdin=None, stdout=None, stderr=None,
                 start_new_session=True)
index 369ec32b755cf02bc7fbf4cf665e7ec417cf60a4..964b2e8ec80bf227de0d7ffdc822d4eada153e24 100644 (file)
@@ -1,6 +1,5 @@
 """Tests for selector_events.py"""
 
-import collections
 import errno
 import gc
 import pprint
@@ -1378,7 +1377,7 @@ class SelectorSslWithoutSslTransportTests(unittest.TestCase):
     def test_ssl_transport_requires_ssl_module(self):
         Mock = mock.Mock
         with self.assertRaises(RuntimeError):
-            transport = _SelectorSslTransport(Mock(), Mock(), Mock(), Mock())
+            _SelectorSslTransport(Mock(), Mock(), Mock(), Mock())
 
 
 class SelectorDatagramTransportTests(unittest.TestCase):
index e921dfe4eb6ec8560c3183c43aee8a210de2d515..031499e8143c3ed2d1b52246364a654ba492b526 100644 (file)
@@ -1,6 +1,5 @@
 """Tests for streams.py."""
 
-import functools
 import gc
 import socket
 import unittest
index 6d03dc78f9f29d4d1978a4503fe5f74119904dc5..ced34312f79751de8b76d164bae18710c4085556 100644 (file)
@@ -830,7 +830,7 @@ class TaskTests(unittest.TestCase):
                 v = yield from f
                 self.assertEqual(v, 'a')
 
-        res = loop.run_until_complete(asyncio.Task(foo(), loop=loop))
+        loop.run_until_complete(asyncio.Task(foo(), loop=loop))
 
     def test_as_completed_reverse_wait(self):
 
@@ -964,13 +964,9 @@ class TaskTests(unittest.TestCase):
         loop = test_utils.TestLoop(gen)
         self.addCleanup(loop.close)
 
-        sleepfut = None
-
         @asyncio.coroutine
         def sleep(dt):
-            nonlocal sleepfut
-            sleepfut = asyncio.sleep(dt, loop=loop)
-            yield from sleepfut
+            yield from asyncio.sleep(dt, loop=loop)
 
         @asyncio.coroutine
         def doit():
index 3b187de9f6e77289fbd2c715155aafb798b5c4d9..cc743839520e1df3d39e43968c627f3d926fd39d 100644 (file)
@@ -1302,7 +1302,7 @@ class ChildWatcherTestsMixin:
         m.waitpid.side_effect = ValueError
 
         with mock.patch.object(log.logger,
-                                        'error') as m_error:
+                               'error') as m_error:
 
             self.assertEqual(self.watcher._sig_chld(), None)
             self.assertTrue(m_error.called)
@@ -1376,19 +1376,16 @@ class ChildWatcherTestsMixin:
         # attach a new loop
         old_loop = self.loop
         self.loop = test_utils.TestLoop()
+        patch = mock.patch.object
 
-        with mock.patch.object(
-                old_loop,
-                "remove_signal_handler") as m_old_remove_signal_handler, \
-             mock.patch.object(
-                self.loop,
-                "add_signal_handler") as m_new_add_signal_handler:
+        with patch(old_loop, "remove_signal_handler") as m_old_remove, \
+             patch(self.loop, "add_signal_handler") as m_new_add:
 
             self.watcher.attach_loop(self.loop)
 
-            m_old_remove_signal_handler.assert_called_once_with(
+            m_old_remove.assert_called_once_with(
                 signal.SIGCHLD)
-            m_new_add_signal_handler.assert_called_once_with(
+            m_new_add.assert_called_once_with(
                 signal.SIGCHLD, self.watcher._sig_chld)
 
         # child terminates
@@ -1462,7 +1459,6 @@ class ChildWatcherTestsMixin:
     def test_close(self, m):
         # register two children
         callback1 = mock.Mock()
-        callback2 = mock.Mock()
 
         with self.watcher:
             self.running = True
index 846049a245a72c1a9530dfc6012317200adc8958..f65225863972699d3a38d843aa4432af09f618b6 100644 (file)
@@ -8,7 +8,6 @@ if sys.platform != 'win32':
 import _winapi
 
 import asyncio
-from asyncio import test_utils
 from asyncio import _overlapped
 from asyncio import windows_events
 
@@ -50,7 +49,7 @@ class ProactorTests(unittest.TestCase):
         ADDRESS = r'\\.\pipe\test_double_bind-%s' % os.getpid()
         server1 = windows_events.PipeServer(ADDRESS)
         with self.assertRaises(PermissionError):
-            server2 = windows_events.PipeServer(ADDRESS)
+            windows_events.PipeServer(ADDRESS)
         server1.close()
 
     def test_pipe(self):