]> granicus.if.org Git - php/commitdiff
MFB: fix #36727 (segfault in pdo_pgsql bindValue() when no parameters are defined)
authorAntony Dovgal <tony2001@php.net>
Fri, 17 Mar 2006 22:17:15 +0000 (22:17 +0000)
committerAntony Dovgal <tony2001@php.net>
Fri, 17 Mar 2006 22:17:15 +0000 (22:17 +0000)
ext/pdo_pgsql/pgsql_statement.c
ext/pdo_pgsql/tests/bug36727.phpt [new file with mode: 0644]

index e47388e072fa594df2377f71b303f09727d048f6..a3f9f908e001c3a19b4cab4f55fe86c9ed9623b9 100644 (file)
@@ -174,7 +174,7 @@ static int pgsql_stmt_param_hook(pdo_stmt_t *stmt, struct pdo_bound_param_data *
                                        } else {
                                                /* resolve parameter name to rewritten name */
                                                char *nameptr;
-                                               if (SUCCESS == zend_hash_find(stmt->bound_param_map,
+                                               if (stmt->bound_param_map && SUCCESS == zend_hash_find(stmt->bound_param_map,
                                                                param->name, param->namelen + 1, (void**)&nameptr)) {
                                                        param->paramno = atoi(nameptr + 1) - 1;
                                                } else {
diff --git a/ext/pdo_pgsql/tests/bug36727.phpt b/ext/pdo_pgsql/tests/bug36727.phpt
new file mode 100644 (file)
index 0000000..c6f7c8a
--- /dev/null
@@ -0,0 +1,23 @@
+--TEST--
+Bug #36727 (segfault in bindValue() when no parameters are defined)
+--SKIPIF--
+<?php
+if (!extension_loaded('pdo') || !extension_loaded('pdo_pgsql')) die('skip not loaded');
+require dirname(__FILE__) . '/../../../ext/pdo/tests/pdo_test.inc';
+require dirname(__FILE__) . '/config.inc';
+PDOTest::skip();
+?>
+--FILE--
+<?php
+require dirname(__FILE__) . '/../../../ext/pdo/tests/pdo_test.inc';
+require dirname(__FILE__) . '/config.inc';
+$db = PDOTest::test_factory(dirname(__FILE__) . '/common.phpt');
+
+$stmt = $db->prepare('SELECT * FROM child');
+var_dump($stmt->bindValue(':test', 1, PDO::PARAM_INT));
+
+echo "Done\n";
+?>
+--EXPECT--
+bool(false)
+Done