Fix order of arguments to SubTransSetParent().

ProcessTwoPhaseBuffer (formerly StandbyRecoverPreparedTransactions)
mixed up the parent and child XIDs when calling SubTransSetParent to
record the transactions' relationship in pg_subtrans.

Remarkably, analysis by Simon Riggs suggests that this doesn't lead to
visible problems (at least, not in non-Assert builds).  That might
explain why we'd not noticed it before.  Nonetheless, it's surely wrong.

This code was born broken, so back-patch to all supported branches.

Discussion: https://postgr.es/m/20110.1492905318@sss.pgh.pa.us

diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c
index ea7bfa0578be785d1f86658808fe8e5106646936..88fa270fe3c69cd4a4968dbc5f41e1f4ee50c008 100644 (file)
--- a/src/backend/access/transam/twophase.c
+++ b/src/backend/access/transam/twophase.c
@@ -1887,7 +1887,7 @@ StandbyRecoverPreparedTransactions(bool overwriteOK)
                                TransactionId subxid = subxids[i];
 
                                Assert(TransactionIdFollows(subxid, xid));
-                               SubTransSetParent(xid, subxid, overwriteOK);
+                               SubTransSetParent(subxid, xid, overwriteOK);
                        }
 
                        pfree(buf);