]> granicus.if.org Git - icu/commitdiff
ICU-21527 Assert pattern equality instead of object equality
authorShane F. Carr <shane@unicode.org>
Tue, 8 Mar 2022 03:17:05 +0000 (19:17 -0800)
committerPeter Edberg <42151464+pedberg-icu@users.noreply.github.com>
Tue, 8 Mar 2022 23:31:52 +0000 (15:31 -0800)
icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberRegressionTests.java

index 37c2cc0f25dc9e2f2d2b8c53df34818c1f500bd0..92e04cfb2cc183daf59ace82206a258ad92c0bc7 100644 (file)
@@ -1537,12 +1537,6 @@ public class NumberRegressionTests extends TestFmwk {
         // trip properly.  Test stream in/out integrity too.
         Locale[] avail = NumberFormat.getAvailableLocales();
         for (int i=0; i<avail.length; ++i) {
-            if ((avail[i].getLanguage().equals("ji") || avail[i].getLanguage().equals("bm")) &&
-                    logKnownIssue(
-                        "21527",
-                        "Remove bad currency test case in NumberRegressionTests.java")) {
-                continue;
-            }
             for (int j=0; j<3; ++j) {
                 NumberFormat nf;
                 switch (j) {
@@ -1566,7 +1560,8 @@ public class NumberRegressionTests extends TestFmwk {
                     // Currency does not travel with the pattern string
                     f2.setCurrency(df.getCurrency());
                 }
-                if (!df.equals(f2)) {
+                // ICU-21527: Test the pattern but not the whole DecimalFormat for equality
+                if (!df.toPattern().equals(f2.toPattern())) {
                     errln("FAIL: " + avail[i] + " #" + j + " -> \"" + pat +
                           "\" -> \"" + f2.toPattern() + "\" for case " + j);
                 }