patch 8.2.2067: cursor position in popup terminal is wrong

Problem:    Cursor position in popup terminal is wrong.
Solution:   Don't check the flags.

diff --git a/src/terminal.c b/src/terminal.c
index 644cddab72c34820c58aa847ed765191bd0f28d7..9729eac8f8673a6bbbb653e982064700b86c395a 100644 (file)
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -2207,10 +2207,8 @@ position_cursor(win_T *wp, VTermPos *pos)
 #ifdef FEAT_PROP_POPUP
     if (popup_is_popup(wp))
     {
-       if ((wp->w_flags & WFLAG_WROW_OFF_ADDED) == 0)
-           wp->w_wrow += popup_top_extra(wp);
-       if ((wp->w_flags & WFLAG_WCOL_OFF_ADDED) == 0)
-           wp->w_wcol += popup_left_extra(wp);
+       wp->w_wrow += popup_top_extra(wp);
+       wp->w_wcol += popup_left_extra(wp);
        wp->w_flags |= WFLAG_WCOL_OFF_ADDED | WFLAG_WROW_OFF_ADDED;
     }
     else

diff --git a/src/testdir/test_popupwin.vim b/src/testdir/test_popupwin.vim
index 45e35030d48b98df5a9b04f69104e2c7ccfdd73c..42542a35c337799a7360ca7cce7240ebee6a1c05 100644 (file)
--- a/src/testdir/test_popupwin.vim
+++ b/src/testdir/test_popupwin.vim
@@ -2662,10 +2662,18 @@ func Test_popupwin_terminal_buffer()
   help
 
   let termbuf = term_start(&shell, #{hidden: 1})
-  let winid = popup_create(termbuf, #{minwidth: 40, minheight: 10})
-  " Wait for shell to start
+  let winid = popup_create(termbuf, #{minwidth: 40, minheight: 10, border: []})
+  " Wait for shell to start and show a prompt
   call WaitForAssert({-> assert_equal("run", job_status(term_getjob(termbuf)))})
-  sleep 100m
+  sleep 20m
+
+  " When typing a character, the cursor is after it.
+  call feedkeys("x", 'xt')
+  sleep 10m
+  redraw
+  call WaitForAssert({ -> assert_equal('x', screenstring(screenrow(), screencol() - 1))})
+  call feedkeys("\<BS>", 'xt')
+
   " Check this doesn't crash
   call assert_equal(winnr(), winnr('j'))
   call assert_equal(winnr(), winnr('k'))

diff --git a/src/version.c b/src/version.c
index b94f0df8009a0b3b8dc5beb1d4934d05bb9d663e..e92d754cf402a27e60cf794c93f4bd7066941040 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -750,6 +750,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    2067,
 /**/
     2066,
 /**/