imap: Reversed the logic of the (un)successful tagged SELECT response

Reversed the logic of the unsuccessful vs successful tagged SELECT
response in imap_state_select_resp() to be more logical to read.

diff --git a/lib/imap.c b/lib/imap.c
index cfde0019ae1b42bec9f1607426a457b8d41d9113..ae2fd4102e1358dd29f747fde7077743322b1287 100644 (file)
--- a/lib/imap.c
+++ b/lib/imap.c
@@ -1233,11 +1233,7 @@ static CURLcode imap_state_select_resp(struct connectdata *conn,
       imapc->mailbox_uidvalidity = strdup(tmp);
     }
   }
-  else if(imapcode != 'O') {
-    failf(data, "Select failed");
-    result = CURLE_LOGIN_DENIED;
-  }
-  else {
+  else if(imapcode == 'O') {
     /* Check if the UIDVALIDITY has been specified and matches */
     if(imap->uidvalidity && imapc->mailbox_uidvalidity &&
        strcmp(imap->uidvalidity, imapc->mailbox_uidvalidity)) {
@@ -1251,6 +1247,10 @@ static CURLcode imap_state_select_resp(struct connectdata *conn,
       result = imap_fetch(conn);
     }
   }
+  else {
+    failf(data, "Select failed");
+    result = CURLE_LOGIN_DENIED;
+  }
 
   return result;
 }