]> granicus.if.org Git - curl/commitdiff
timeval.c: Use long long constant type for timeval assignment
authorMartin Kepplinger <martink@posteo.de>
Mon, 3 Jul 2017 11:23:47 +0000 (13:23 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Tue, 4 Jul 2017 05:59:21 +0000 (07:59 +0200)
On a 64 bit host, sparse says:

timeval.c:148:15: warning: constant 0x7fffffffffffffff is so big it is long
timeval.c:149:12: warning: constant 0x7fffffffffffffff is so big it is long

so let's use long long constant types in order to prevent undesired overflow
failures.

Bug: https://curl.haxx.se/mail/lib-2017-07/0003.html

Closes #1636

Signed-off-by: Martin Kepplinger <martink@posteo.de>
lib/timeval.c

index 1012b4e39d72335db4aab9b14a260d654099e152..aff53cddce5fad164b3f98a5bc1c79cfb11114f0 100644 (file)
@@ -145,8 +145,8 @@ time_t Curl_tvdiff_us(struct timeval newer, struct timeval older)
     return 0x7fffffff;
 #else
   /* for 64bit time_t systems */
-  if(diff >= (0x7fffffffffffffff/1000000))
-    return 0x7fffffffffffffff;
+  if(diff >= (0x7fffffffffffffffLL/1000000))
+    return 0x7fffffffffffffffLL;
 #endif
   return (newer.tv_sec-older.tv_sec)*1000000+
     (time_t)(newer.tv_usec-older.tv_usec);