]> granicus.if.org Git - handbrake/commitdiff
MacGui: Cleanup HBPreferncesController and the preferences nib a little. Original...
authorritsuka <damiog@gmail.com>
Wed, 26 Nov 2008 17:00:28 +0000 (17:00 +0000)
committerritsuka <damiog@gmail.com>
Wed, 26 Nov 2008 17:00:28 +0000 (17:00 +0000)
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@1956 b64f7644-9d1e-0410-96f1-a4d463321fa5

macosx/English.lproj/Preferences.xib
macosx/HBPreferencesController.m

index 800d4088c90f41ee7f907d357c9d734d8c680461..c6bcf1acc7a2055e31a8bbc6e044b37c67e19b48 100644 (file)
@@ -3,14 +3,15 @@
        <data>
                <int key="IBDocument.SystemTarget">1050</int>
                <string key="IBDocument.SystemVersion">9F33</string>
-               <string key="IBDocument.InterfaceBuilderVersion">670</string>
+               <string key="IBDocument.InterfaceBuilderVersion">672</string>
                <string key="IBDocument.AppKitVersion">949.34</string>
                <string key="IBDocument.HIToolboxVersion">352.00</string>
                <object class="NSMutableArray" key="IBDocument.EditedObjectIDs">
                        <bool key="EncodedWithXMLCoder">YES</bool>
-                       <integer value="236"/>
                        <integer value="234"/>
                        <integer value="233"/>
+                       <integer value="235"/>
+                       <integer value="236"/>
                </object>
                <object class="NSArray" key="IBDocument.PluginDependencies">
                        <bool key="EncodedWithXMLCoder">YES</bool>
                                        <object class="NSTextField" id="1062449667">
                                                <reference key="NSNextResponder" ref="520288288"/>
                                                <int key="NSvFlags">268</int>
-                                               <string key="NSFrame">{{188, 38}, {113, 22}}</string>
+                                               <string key="NSFrame">{{207, 40}, {208, 22}}</string>
                                                <reference key="NSSuperview" ref="520288288"/>
                                                <bool key="NSEnabled">YES</bool>
                                                <object class="NSTextFieldCell" key="NSCell" id="51555548">
                                        <object class="NSTextField" id="539748933">
                                                <reference key="NSNextResponder" ref="520288288"/>
                                                <int key="NSvFlags">268</int>
-                                               <string key="NSFrame">{{27, 40}, {155, 17}}</string>
+                                               <string key="NSFrame">{{47, 42}, {155, 17}}</string>
                                                <reference key="NSSuperview" ref="520288288"/>
                                                <bool key="NSEnabled">YES</bool>
                                                <object class="NSTextFieldCell" key="NSCell" id="374363387">
                                                </object>
                                        </object>
                                </object>
-                               <string key="NSFrameSize">{496, 80}</string>
+                               <string key="NSFrameSize">{496, 82}</string>
                                <reference key="NSSuperview"/>
                                <string key="NSClassName">NSView</string>
                                <string key="NSExtension">NSResponder</string>
                        </object>
                        <object class="NSCustomView" id="332598366">
-                               <nil key="NSNextResponder"/>
+                               <reference key="NSNextResponder"/>
                                <int key="NSvFlags">256</int>
                                <object class="NSMutableArray" key="NSSubviews">
                                        <bool key="EncodedWithXMLCoder">YES</bool>
                                        <object class="NSTextField" id="389101877">
                                                <reference key="NSNextResponder" ref="332598366"/>
                                                <int key="NSvFlags">256</int>
-                                               <string key="NSFrame">{{76, 43}, {114, 17}}</string>
+                                               <string key="NSFrame">{{76, 42}, {114, 17}}</string>
                                                <reference key="NSSuperview" ref="332598366"/>
                                                <bool key="NSEnabled">YES</bool>
                                                <object class="NSTextFieldCell" key="NSCell" id="459708758">
                                        <object class="NSComboBox" id="172081130">
                                                <reference key="NSNextResponder" ref="332598366"/>
                                                <int key="NSvFlags">256</int>
-                                               <string key="NSFrame">{{195, 39}, {229, 26}}</string>
+                                               <string key="NSFrame">{{195, 38}, {229, 26}}</string>
                                                <reference key="NSSuperview" ref="332598366"/>
                                                <bool key="NSEnabled">YES</bool>
                                                <object class="NSComboBoxCell" key="NSCell" id="210320026">
                                                                <object class="NSMutableArray" key="NSTableColumns">
                                                                        <bool key="EncodedWithXMLCoder">YES</bool>
                                                                        <object class="NSTableColumn">
-                                                                               <integer value="0" key="NSIdentifier"/>
+                                                                               <integer value="0" key="NSIdentifier" id="8"/>
                                                                                <double key="NSWidth">1.000000e+01</double>
                                                                                <double key="NSMinWidth">1.000000e+01</double>
                                                                                <double key="NSMaxWidth">1.000000e+03</double>
                                        <object class="NSButton" id="168948265">
                                                <reference key="NSNextResponder" ref="332598366"/>
                                                <int key="NSvFlags">-2147483392</int>
-                                               <string key="NSFrame">{{18, 18}, {472, 18}}</string>
+                                               <string key="NSFrame">{{18, 17}, {472, 18}}</string>
                                                <reference key="NSSuperview" ref="332598366"/>
                                                <bool key="NSEnabled">YES</bool>
                                                <object class="NSButtonCell" key="NSCell" id="686321393">
                                                </object>
                                        </object>
                                </object>
-                               <string key="NSFrameSize">{500, 83}</string>
+                               <string key="NSFrameSize">{500, 82}</string>
+                               <reference key="NSSuperview"/>
                                <object class="NSMutableString" key="NSClassName">
                                        <characters key="NS.bytes">NSView</characters>
                                </object>
                                        <object class="NSButton" id="882188042">
                                                <reference key="NSNextResponder" ref="23728330"/>
                                                <int key="NSvFlags">256</int>
-                                               <string key="NSFrame">{{83, 146}, {367, 18}}</string>
+                                               <string key="NSFrame">{{84, 44}, {367, 18}}</string>
                                                <reference key="NSSuperview" ref="23728330"/>
                                                <bool key="NSEnabled">YES</bool>
                                                <object class="NSButtonCell" key="NSCell" id="197383193">
                                        <object class="NSTextField" id="759266151">
                                                <reference key="NSNextResponder" ref="23728330"/>
                                                <int key="NSvFlags">256</int>
-                                               <string key="NSFrame">{{39, 147}, {41, 17}}</string>
+                                               <string key="NSFrame">{{40, 45}, {41, 17}}</string>
                                                <reference key="NSSuperview" ref="23728330"/>
                                                <bool key="NSEnabled">YES</bool>
                                                <object class="NSTextFieldCell" key="NSCell" id="488653412">
                                                        <reference key="NSTextColor" ref="887152126"/>
                                                </object>
                                        </object>
+                                       <object class="NSTextField" id="899831697">
+                                               <reference key="NSNextResponder" ref="23728330"/>
+                                               <int key="NSvFlags">256</int>
+                                               <string key="NSFrame">{{49, 20}, {32, 17}}</string>
+                                               <reference key="NSSuperview" ref="23728330"/>
+                                               <bool key="NSEnabled">YES</bool>
+                                               <object class="NSTextFieldCell" key="NSCell" id="483848741">
+                                                       <int key="NSCellFlags">67239424</int>
+                                                       <int key="NSCellFlags2">272629760</int>
+                                                       <string key="NSContents">Log:</string>
+                                                       <reference key="NSSupport" ref="964910696"/>
+                                                       <reference key="NSControlView" ref="899831697"/>
+                                                       <reference key="NSBackgroundColor" ref="525377782"/>
+                                                       <reference key="NSTextColor" ref="887152126"/>
+                                               </object>
+                                       </object>
                                        <object class="NSButton" id="907177043">
                                                <reference key="NSNextResponder" ref="23728330"/>
                                                <int key="NSvFlags">256</int>
-                                               <string key="NSFrame">{{83, 108}, {367, 18}}</string>
+                                               <string key="NSFrame">{{84, 18}, {367, 18}}</string>
                                                <reference key="NSSuperview" ref="23728330"/>
                                                <bool key="NSEnabled">YES</bool>
                                                <object class="NSButtonCell" key="NSCell" id="869757541">
                                                </object>
                                        </object>
                                </object>
-                               <string key="NSFrameSize">{500, 184}</string>
+                               <string key="NSFrameSize">{492, 82}</string>
                                <reference key="NSSuperview"/>
                                <object class="NSMutableString" key="NSClassName">
                                        <characters key="NS.bytes">NSView</characters>
                                                <reference key="object" ref="520288288"/>
                                                <object class="NSMutableArray" key="children">
                                                        <bool key="EncodedWithXMLCoder">YES</bool>
-                                                       <reference ref="1062449667"/>
                                                        <reference ref="539748933"/>
+                                                       <reference ref="1062449667"/>
                                                </object>
                                                <reference key="parent" ref="510204080"/>
                                                <string key="objectName">Picture</string>
                                                        <bool key="EncodedWithXMLCoder">YES</bool>
                                                        <reference ref="882188042"/>
                                                        <reference ref="759266151"/>
+                                                       <reference ref="899831697"/>
                                                        <reference ref="907177043"/>
                                                </object>
                                                <reference key="parent" ref="510204080"/>
                                                <reference key="object" ref="869757541"/>
                                                <reference key="parent" ref="907177043"/>
                                        </object>
+                                       <object class="IBObjectRecord">
+                                               <int key="objectID">350</int>
+                                               <reference key="object" ref="899831697"/>
+                                               <object class="NSMutableArray" key="children">
+                                                       <bool key="EncodedWithXMLCoder">YES</bool>
+                                                       <reference ref="483848741"/>
+                                               </object>
+                                               <reference key="parent" ref="23728330"/>
+                                       </object>
+                                       <object class="IBObjectRecord">
+                                               <int key="objectID">351</int>
+                                               <reference key="object" ref="483848741"/>
+                                               <reference key="parent" ref="899831697"/>
+                                       </object>
                                </object>
                        </object>
                        <object class="NSMutableDictionary" key="flattenedProperties">
                                        <string>234.IBPluginDependency</string>
                                        <string>234.ImportedFromIB2</string>
                                        <string>234.editorWindowContentRectSynchronizationRect</string>
+                                       <string>235.IBEditorWindowLastContentRect</string>
                                        <string>235.IBPluginDependency</string>
                                        <string>235.ImportedFromIB2</string>
                                        <string>236.IBEditorWindowLastContentRect</string>
                                        <string>327.IBPluginDependency</string>
                                        <string>347.IBPluginDependency</string>
                                        <string>347.ImportedFromIB2</string>
+                                       <string>350.IBPluginDependency</string>
+                                       <string>350.ImportedFromIB2</string>
                                        <string>5.IBPluginDependency</string>
                                        <string>5.ImportedFromIB2</string>
                                        <string>5.windowTemplate.hasMaxSize</string>
                                        <bool key="EncodedWithXMLCoder">YES</bool>
                                        <string>com.apple.InterfaceBuilder.CocoaPlugin</string>
                                        <string>com.apple.InterfaceBuilder.CocoaPlugin</string>
-                                       <string>{{28, 401}, {492, 189}}</string>
+                                       <string>{{418, 501}, {492, 189}}</string>
                                        <string>com.apple.InterfaceBuilder.CocoaPlugin</string>
                                        <reference ref="9"/>
                                        <string>{{0, 636}, {500, 209}}</string>
-                                       <string>{{27, 609}, {496, 80}}</string>
+                                       <string>{{144, 376}, {496, 82}}</string>
                                        <string>com.apple.InterfaceBuilder.CocoaPlugin</string>
                                        <reference ref="9"/>
                                        <string>{{0, 726}, {500, 108}}</string>
+                                       <string>{{73, 902}, {500, 82}}</string>
                                        <string>com.apple.InterfaceBuilder.CocoaPlugin</string>
                                        <reference ref="9"/>
-                                       <string>{{110, 672}, {500, 184}}</string>
+                                       <string>{{110, 774}, {492, 82}}</string>
                                        <string>com.apple.InterfaceBuilder.CocoaPlugin</string>
                                        <reference ref="9"/>
                                        <string>{{0, 650}, {500, 184}}</string>
                                        <reference ref="9"/>
                                        <string>com.apple.InterfaceBuilder.CocoaPlugin</string>
                                        <reference ref="9"/>
+                                       <string>com.apple.InterfaceBuilder.CocoaPlugin</string>
                                        <reference ref="9"/>
+                                       <reference ref="8"/>
                                        <reference ref="9"/>
                                        <string>{3.40282e+38, 3.40282e+38}</string>
                                        <string>{213, 107}</string>
                                </object>
                        </object>
                        <nil key="sourceID"/>
-                       <int key="maxID">349</int>
+                       <int key="maxID">351</int>
                </object>
                <object class="IBClassDescriber" key="IBDocument.Classes">
                        <object class="NSMutableArray" key="referencedPartialClassDescriptions">
index 701b95fed42d03a3bd866bd3103eaa2f829ffd4c..758b8b718ddc8e3a9ed172b02c594f1e57071650 100644 (file)
 @interface HBPreferencesController (Private)
 
 - (void) setPrefView: (id) sender;
+- (NSToolbarItem *)toolbarItemWithIdentifier: (NSString *)identifier
+                                       label: (NSString *)label
+                                       image: (NSImage *)image;
 
 @end
 
 @implementation HBPreferencesController
 
 /**
+ * +[HBPreferencesController registerUserDefaults]
+ *
  * Registers default values to user defaults. This is called immediately
  * when HandBrake starts, from [HBController init].
  */
 }
 
 /**
+ * -[HBPreferencesController init]
+ *
  * Initializes the preferences controller by loading Preferences.nib file.
+ *
  */
 - (id)init
 {
     return self;
 }
 
+/**
+ * -[HBPreferencesController awakeFromNib]
+ *
+ * Called after all the outlets in the nib file have been attached. Sets up the
+ * toolbar and shows the "General" pane.
+ *
+ */
 - (void) awakeFromNib
 {
     NSToolbar * toolbar = [[[NSToolbar alloc] initWithIdentifier: @"Preferences Toolbar"] autorelease];
     [self setPrefView:nil];
 }
 
-- (NSToolbarItem *) toolbar: (NSToolbar *) toolbar itemForItemIdentifier: (NSString *) ident
-                    willBeInsertedIntoToolbar: (BOOL) flag
+- (NSToolbarItem *)toolbar: (NSToolbar *)toolbar
+     itemForItemIdentifier: (NSString *)ident
+ willBeInsertedIntoToolbar: (BOOL)flag
 {
-    NSToolbarItem * item;
-    item = [[[NSToolbarItem alloc] initWithItemIdentifier: ident] autorelease];
-
-    if ([ident isEqualToString: TOOLBAR_GENERAL])
-    {
-        [item setLabel: NSLocalizedString(@"General", "General")];
-        [item setImage: [NSImage imageNamed: @"NSPreferencesGeneral"]];
-        [item setTarget: self];
-        [item setAction: @selector(setPrefView:)];
-        [item setAutovalidates: NO];
-    }
-    else if ([ident isEqualToString: TOOLBAR_PICTURE])
+    if ( [ident isEqualToString:TOOLBAR_GENERAL] )
     {
-        [item setLabel: NSLocalizedString(@"Picture", "Picture")];
-        [item setImage: [NSImage imageNamed: @"pref-picture"]];
-        [item setTarget: self];
-        [item setAction: @selector(setPrefView:)];
-        [item setAutovalidates: NO];
+        return [self toolbarItemWithIdentifier:ident
+                                         label:NSLocalizedString(@"General", @"Preferences General Toolbar Item")
+                                         image:[NSImage imageNamed:NSImageNamePreferencesGeneral]];
     }
-    else if ([ident isEqualToString: TOOLBAR_AUDIO])
+    else if ( [ident isEqualToString:TOOLBAR_PICTURE] )
     {
-        [item setLabel: NSLocalizedString(@"Audio", "Audio")];
-        [item setImage: [NSImage imageNamed: @"pref-audio"]];
-        [item setTarget: self];
-        [item setAction: @selector(setPrefView:)];
-        [item setAutovalidates: NO];
+        return [self toolbarItemWithIdentifier:ident
+                                         label:NSLocalizedString(@"Picture", @"Preferences Picture Toolbar Item")
+                                         image:[NSImage imageNamed:@"pref-picture"]];
     }
-    else if ([ident isEqualToString: TOOLBAR_ADVANCED])
+    else if ( [ident isEqualToString:TOOLBAR_AUDIO] )
     {
-        [item setLabel: NSLocalizedString(@"Advanced", "Advanced")];
-        [item setImage: [NSImage imageNamed: @"NSAdvanced"]];
-        [item setTarget: self];
-        [item setAction: @selector(setPrefView:)];
-        [item setAutovalidates: NO];
+        return [self toolbarItemWithIdentifier:ident
+                                         label:NSLocalizedString(@"Audio", @"Preferences Audio Toolbar Item")
+                                         image:[NSImage imageNamed:@"pref-audio"]];
     }
-    else
+    else if ( [ident isEqualToString:TOOLBAR_ADVANCED] )
     {
-        return nil;
+        return [self toolbarItemWithIdentifier:ident
+                                         label:NSLocalizedString(@"Advanced", @"Preferences Advanced Toolbar Item")
+                                         image:[NSImage imageNamed:NSImageNameAdvanced]];
     }
 
-    return item;
+    return nil;
 }
 
 - (NSArray *) toolbarSelectableItemIdentifiers: (NSToolbar *) toolbar
     }
 }
 
+/**
+ * -[HBPreferencesController(Private) toolbarItemWithIdentifier:label:image:]
+ *
+ * Shared code for creating the NSToolbarItems for the Preferences toolbar.
+ *
+ */
+- (NSToolbarItem *)toolbarItemWithIdentifier: (NSString *)identifier
+                                       label: (NSString *)label
+                                       image: (NSImage *)image
+{
+    NSToolbarItem *item = [[NSToolbarItem alloc] initWithItemIdentifier:identifier];
+    [item setLabel:label];
+    [item setImage:image];
+    [item setAction:@selector(setPrefView:)];
+    [item setAutovalidates:NO];
+    return [item autorelease];
+}
+
 @end