MFH: fix potential problem in php_oci_bind_post_exec() when OCIDateToText() fails
authorAntony Dovgal <tony2001@php.net>
Thu, 1 Dec 2005 13:47:22 +0000 (13:47 +0000)
committerAntony Dovgal <tony2001@php.net>
Thu, 1 Dec 2005 13:47:22 +0000 (13:47 +0000)
ext/oci8/oci8_statement.c

index 3927392e3029bf00e35b15e8eb84805419821dd2..a56f7a69616f6a864cd694b4f9dcaf52787a9e25 100644 (file)
@@ -697,7 +697,9 @@ int php_oci_bind_post_exec(void *data TSRMLS_DC)
                                                        php_oci_error(connection->err, connection->errcode TSRMLS_CC);
                                                        ZVAL_NULL(*entry);
                                                }
-                                               ZVAL_STRINGL(*entry, buff, buff_len, 1);
+                                               else {
+                                                       ZVAL_STRINGL(*entry, buff, buff_len, 1);
+                                               }
                                                zend_hash_move_forward(hash);
                                        }
                                        else {
@@ -706,7 +708,9 @@ int php_oci_bind_post_exec(void *data TSRMLS_DC)
                                                        php_oci_error(connection->err, connection->errcode TSRMLS_CC);
                                                        add_next_index_null(bind->zval);
                                                }
-                                               add_next_index_stringl(bind->zval, buff, buff_len, 1);
+                                               else {
+                                                       add_next_index_stringl(bind->zval, buff, buff_len, 1);
+                                               }
                                        }
                                }
                                break;