]> granicus.if.org Git - php/commitdiff
Added some notes about the brigade bug detection
authorMoriyoshi Koizumi <moriyoshi@php.net>
Sat, 21 Dec 2002 06:33:19 +0000 (06:33 +0000)
committerMoriyoshi Koizumi <moriyoshi@php.net>
Sat, 21 Dec 2002 06:33:19 +0000 (06:33 +0000)
sapi/apache2filter/sapi_apache2.c

index 0355cf66ccf421409f0e67879d017da8e9b29844..47fdc975f43a613f23749ec3af55c593ac7c27b1 100644 (file)
@@ -335,6 +335,16 @@ static int php_input_filter(ap_filter_t *f, apr_bucket_brigade *bb,
 
        for (b = APR_BRIGADE_FIRST(bb); b != APR_BRIGADE_SENTINEL(bb); b = APR_BUCKET_NEXT(b)) {
                apr_bucket_read(b, &str, &n, 1);
+
+               /*
+         * An intuitive brigade bug detection
+                * (http://bugs.php.net/18648)  
+                *
+         * This has something to do with the issue mentioned in this thread
+         * on dev@httpd.apache.org:
+                *
+         * http://marc.theaimsgroup.com/?l=apr-dev&m=104039770818472&w=2
+         */
                if (APR_BUCKET_IS_HEAP(b)) {
                        if ((str == prev_fetched_str && n == prev_fetched_str_len)) {
                                char *brigade_dump = NULL;