]> granicus.if.org Git - libevent/commitdiff
Make the new http_connect_fail_test use a multicast addr, not broadcast
authorNick Mathewson <nickm@torproject.org>
Sat, 28 May 2011 03:28:17 +0000 (23:28 -0400)
committerNick Mathewson <nickm@torproject.org>
Sat, 28 May 2011 03:30:06 +0000 (23:30 -0400)
Turns out that FreeBSD does _not_ give a ENETUNREACH error when
told to make a TCP socket to 255.255.255.255, but it is quite happy
to do so for 239.10.20.30.  So that's what we'll do.

Found by Robert Ransom and Dave Hart.

test/regress_http.c

index cf0fb97147734fffa07f09a760e957206c9bb467..0aef4d7405401ce2bd82d28e8ea58fa945bafd0b 100644 (file)
@@ -3040,9 +3040,9 @@ http_connection_fail_test(void *arg)
        evhttp_free(http);
        http = NULL;
 
-       /* Pick an unroutable address.  The limited broadcast address should do
-        * when working with TCP. */
-       evcon = evhttp_connection_base_new(data->base, NULL, "255.255.255.255", 80);
+       /* Pick an unroutable address.  This administratively scoped multicast
+       * address should do when working with TCP. */
+       evcon = evhttp_connection_base_new(data->base, NULL, "239.10.20.30", 80);
        tt_assert(evcon);
 
        /*