]> granicus.if.org Git - postgresql/commitdiff
Fix advertised dispsize for libpq's sslmode connection parameter.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 17 Mar 2014 01:43:40 +0000 (21:43 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 17 Mar 2014 01:43:40 +0000 (21:43 -0400)
"8" was correct back when "disable" was the longest allowed value, but
since "verify-full" was added, it should be "12".  Given the lack of
complaints, I wouldn't be surprised if nobody is actually using these
values ... but still, if they're in the API, they should be right.

Noticed while pursuing a different problem.  It's been wrong for quite
a long time, so back-patch to all supported branches.

src/interfaces/libpq/fe-connect.c

index dedb6e74f132a893183acadacd8dc7164cfe6930..da8335e6805ac576596f7761d9fa9d1253309d92 100644 (file)
@@ -251,7 +251,7 @@ static const internalPQconninfoOption PQconninfoOptions[] = {
         * to exclude them since none of them are mandatory.
         */
        {"sslmode", "PGSSLMODE", DefaultSSLMode, NULL,
-               "SSL-Mode", "", 8,              /* sizeof("disable") == 8 */
+               "SSL-Mode", "", 12,             /* sizeof("verify-full") == 12 */
        offsetof(struct pg_conn, sslmode)},
 
        {"sslcompression", "PGSSLCOMPRESSION", "1", NULL,