]> granicus.if.org Git - ipset/commitdiff
netfilter: ipset: hash: fix boolreturn.cocci warnings
authorkbuild test robot <fengguang.wu@intel.com>
Sat, 15 Oct 2016 01:13:14 +0000 (09:13 +0800)
committerJozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Sat, 15 Oct 2016 08:14:31 +0000 (10:14 +0200)
net/netfilter/ipset/ip_set_hash_ipmac.c:70:8-9: WARNING: return of 0/1 in function 'hash_ipmac4_data_list' with return type bool
net/netfilter/ipset/ip_set_hash_ipmac.c:178:8-9: WARNING: return of 0/1 in function 'hash_ipmac6_data_list' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: Tomasz Chilinski <tomasz.chilinski@chilan.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
kernel/net/netfilter/ipset/ip_set_hash_ipmac.c

index d9eb144b01d624c4988a8393e1cd1fc5bf6456e9..1ab5ed2f6839a9acc83f5b040e989889cb74de12 100644 (file)
@@ -67,10 +67,10 @@ hash_ipmac4_data_list(struct sk_buff *skb, const struct hash_ipmac4_elem *e)
        if (nla_put_ipaddr4(skb, IPSET_ATTR_IP, e->ip) ||
            nla_put(skb, IPSET_ATTR_ETHER, ETH_ALEN, e->ether))
                goto nla_put_failure;
-       return 0;
+       return false;
 
 nla_put_failure:
-       return 1;
+       return true;
 }
 
 static inline void
@@ -175,10 +175,10 @@ hash_ipmac6_data_list(struct sk_buff *skb, const struct hash_ipmac6_elem *e)
        if (nla_put_ipaddr6(skb, IPSET_ATTR_IP, &e->ip.in6) ||
            nla_put(skb, IPSET_ATTR_ETHER, ETH_ALEN, e->ether))
                goto nla_put_failure;
-       return 0;
+       return false;
 
 nla_put_failure:
-       return 1;
+       return true;
 }
 
 static inline void