]> granicus.if.org Git - pdns/commitdiff
Lowercase names when inserting in the database
authorPieter Lexis <pieter.lexis@powerdns.com>
Thu, 24 Mar 2016 08:17:28 +0000 (09:17 +0100)
committerPieter Lexis <pieter.lexis@powerdns.com>
Thu, 24 Mar 2016 08:18:04 +0000 (09:18 +0100)
Closes #3583

pdns/backends/gsql/gsqlbackend.cc
pdns/backends/gsql/ssql.hh

index c607b17114aebba221bfa59ad4e12d2b68a40a2a..bcba0baef3f765532d7c98fc59b6772e6a2be4bd 100644 (file)
@@ -1305,7 +1305,7 @@ bool GSQLBackend::feedRecord(const DNSResourceRecord &r, string *ordername)
       bind("qtype",r.qtype.getName())->
       bind("domain_id",r.domain_id)->
       bind("disabled",r.disabled)->
-      bind("qname",stripDot(r.qname.toString())); // FIXME400 lowercase?
+      bind("qname",r.qname);
 
     if (ordername == NULL)
       d_InsertRecordQuery_stmt->bindNull("ordername");
index 293b2dce2416a09f80832d7a0f5db390fe2944ce..3b43b24710d56024acf46497fc07cb5b41e7fcfd 100644 (file)
@@ -47,7 +47,7 @@ public:
   virtual SSqlStatement* bind(const string& name, unsigned long long value)=0;
   virtual SSqlStatement* bind(const string& name, const std::string& value)=0;
   SSqlStatement* bind(const string& name, const DNSName& value) {
-    return bind(name, toLower(value.toStringNoDot())); // FIXME400 toLower()?
+    return bind(name, toLower(value.toStringNoDot()));
   }
   virtual SSqlStatement* bindNull(const string& name)=0;
   virtual SSqlStatement* execute()=0;;