Style and safety fixes backported from taglib-extras

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@961000 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

diff --git a/taglib/mp4/mp4tag.cpp b/taglib/mp4/mp4tag.cpp
index 229c4755a46e740f29ef4170803f7c9431afdeda..47a5b79d4581948fc55bbb289b8e83c6b4b2523b 100644 (file)
--- a/taglib/mp4/mp4tag.cpp
+++ b/taglib/mp4/mp4tag.cpp
@@ -79,6 +79,11 @@ MP4::Tag::Tag(File *file, MP4::Atoms *atoms)
   }
 }
 
+MP4::Tag::~Tag()
+{
+  delete d;
+}
+
 ByteVectorList
 MP4::Tag::parseData(MP4::Atom *atom, TagLib::File *file, int expectedFlags, bool freeForm)
 {
@@ -167,7 +172,7 @@ MP4::Tag::parseFreeForm(MP4::Atom *atom, TagLib::File *file)
     for(unsigned int i = 2; i < data.size(); i++) {
       value.append(String(data[i], String::UTF8));
     }
-    String name = "----:" + data[0] + ":" + data[1];
+    String name = "----:" + data[0] + ':' + data[1];
     d->items.insert(name, value);
   }
 }

diff --git a/taglib/mp4/mp4tag.h b/taglib/mp4/mp4tag.h
index 4671d16cbc64baa4d396f986e733fe4d5318f372..41b76657a5f6092fa3deec14d741bddcfbaf0f47 100644 (file)
--- a/taglib/mp4/mp4tag.h
+++ b/taglib/mp4/mp4tag.h
@@ -45,6 +45,7 @@ namespace TagLib {
     {
     public:
         Tag(TagLib::File *file, Atoms *atoms);
+        ~Tag();
         bool save();
 
         String title() const;