Compare value instead of string pointer

Remove unused label
Remove unused var

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1157357 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/modules/aaa/mod_authnz_ldap.c b/modules/aaa/mod_authnz_ldap.c
index eba5cbfe45ce4936078afb0b43127273cebb5a63..d32f84f899eb7ff557d34eb1731b13153a660500 100644 (file)
--- a/modules/aaa/mod_authnz_ldap.c
+++ b/modules/aaa/mod_authnz_ldap.c
@@ -451,7 +451,6 @@ static util_ldap_connection_t *get_connection_for_authz(request_rec *r, enum aut
 static authn_status authn_ldap_check_password(request_rec *r, const char *user,
                                               const char *password)
 {
-    int failures = 0;
     char filtbuf[FILTER_LENGTH];
     authn_ldap_config_t *sec =
         (authn_ldap_config_t *)ap_get_module_config(r->per_dir_config, &authnz_ldap_module);
@@ -479,8 +478,6 @@ static authn_status authn_ldap_check_password(request_rec *r, const char *user,
         return AUTH_GENERAL_ERROR;
     }
 
-start_over:
-
     /* There is a good AuthLDAPURL, right? */
     if (sec->host) {
         const char *binddn = sec->binddn;

diff --git a/modules/ldap/util_ldap.c b/modules/ldap/util_ldap.c
index 8a27156d4a64a3a8b7e57303520863695541f5da..e0185949c3b6ab5f3d84b6ba010fa324282053da 100644 (file)
--- a/modules/ldap/util_ldap.c
+++ b/modules/ldap/util_ldap.c
@@ -2684,7 +2684,7 @@ static const char *util_ldap_set_retries(cmd_parms *cmd,
     }
 
     st->retries = atoi(val);
-    if (val < 0) { 
+    if (st->retries < 0) { 
         return  "LDAPRetries must be >= 0";
     }