]> granicus.if.org Git - python/commitdiff
Suppress clang warning (GH-12384)
authorRémi Lapeyre <remi.lapeyre@henki.fr>
Fri, 3 May 2019 23:30:53 +0000 (01:30 +0200)
committerInada Naoki <songofacandy@gmail.com>
Fri, 3 May 2019 23:30:53 +0000 (08:30 +0900)
Modules/posixmodule.c

index 56ec3ee5a0eed3422d2a6b7f9ef7ef8eeddea11c..221f7101b21356f02a60745fc244affd17e7367d 100644 (file)
@@ -1259,7 +1259,8 @@ _Py_Sigset_Converter(PyObject *obj, void *addr)
     long signum;
     int overflow;
 
-    if (sigemptyset(mask)) {
+    // The extra parens suppress the unreachable-code warning with clang on MacOS
+    if (sigemptyset(mask) < (0)) {
         /* Probably only if mask == NULL. */
         PyErr_SetFromErrno(PyExc_OSError);
         return 0;