Having a signed one-bit bitfield is quite odd -- its value is either

0 or -1.  Although the current code is not broken because it doesn't
test equality to 1, IMHO it's better not to use that.

diff --git a/imap/imap_private.h b/imap/imap_private.h
index 0a554097178b6c418b7128c6a6d635975509805e..9905f5b993898ec14206527a2a26a8a1c2bc228c 100644 (file)
--- a/imap/imap_private.h
+++ b/imap/imap_private.h
@@ -178,7 +178,7 @@ typedef struct
   unsigned char rights[(RIGHTSMAX + 7)/8];
   unsigned int newMailCount;
   IMAP_CACHE cache[IMAP_CACHE_LEN];
-  int noclose : 1;
+  unsigned int noclose : 1;
   
   /* all folder flags - system flags AND keywords */
   LIST *flags;