]> granicus.if.org Git - llvm/commitdiff
Fixed the lost FastMathFlags in Reassociate optimization.
authorVyacheslav Klochkov <vyacheslav.n.klochkov@gmail.com>
Tue, 22 Nov 2016 20:23:04 +0000 (20:23 +0000)
committerVyacheslav Klochkov <vyacheslav.n.klochkov@gmail.com>
Tue, 22 Nov 2016 20:23:04 +0000 (20:23 +0000)
Reviewer: Hal Finkel.
Differential Revision: https://reviews.llvm.org/D26957

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@287695 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Transforms/Scalar/Reassociate.cpp
test/Transforms/Reassociate/propagate-flags.ll [new file with mode: 0644]

index 40c1e3717a270ddf3adc2c9ce388fc62160b2110..181a324861e7e208e8c7e41f70bdb979fac90eff 100644 (file)
@@ -1778,6 +1778,12 @@ Value *ReassociatePass::OptimizeMul(BinaryOperator *I,
     return nullptr; // All distinct factors, so nothing left for us to do.
 
   IRBuilder<> Builder(I);
+  // The reassociate transformation for FP operations is performed only
+  // if unsafe algebra is permitted by FastMathFlags. Propagate those flags
+  // to the newly generated operations.
+  if (auto FPI = dyn_cast<FPMathOperator>(I))
+    Builder.setFastMathFlags(FPI->getFastMathFlags());
+
   Value *V = buildMinimalMultiplyDAG(Builder, Factors);
   if (Ops.empty())
     return V;
diff --git a/test/Transforms/Reassociate/propagate-flags.ll b/test/Transforms/Reassociate/propagate-flags.ll
new file mode 100644 (file)
index 0000000..b898785
--- /dev/null
@@ -0,0 +1,14 @@
+; RUN: opt < %s -reassociate -S | FileCheck %s
+; CHECK-LABEL: func
+; CHECK:       fmul fast double
+; CHECK-NEXT:  fmul fast double
+; CHECK-NEXT:  ret
+
+define double @func(double %a, double %b) {
+entry:
+  %mul1 = fmul fast double %a, %a
+  %mul2 = fmul fast double %b, %b
+  %mul3 = fmul fast double %mul1, %mul2
+  ret double %mul3
+}