Use an event variable to wait for the server to be ready, rather than sleep(0.1).
authorGuido van Rossum <guido@python.org>
Fri, 10 Aug 2007 21:28:41 +0000 (21:28 +0000)
committerGuido van Rossum <guido@python.org>
Fri, 10 Aug 2007 21:28:41 +0000 (21:28 +0000)
Lib/test/test_telnetlib.py

index 0a3604e5ae1e7dfb5ade24df25f3d399beb01a31..c48de04610ce4c5bc15b2a1565832a0c419bcbdc 100644 (file)
@@ -7,12 +7,13 @@ from unittest import TestCase
 from test import test_support
 
 
-def server(evt):
+def server(evt, ready):
     serv = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
     serv.settimeout(3)
     serv.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
     serv.bind(("", 9091))
     serv.listen(5)
+    ready.set()
     try:
         conn, addr = serv.accept()
     except socket.timeout:
@@ -25,8 +26,9 @@ class GeneralTests(TestCase):
 
     def setUp(self):
         self.evt = threading.Event()
-        threading.Thread(target=server, args=(self.evt,)).start()
-        time.sleep(.1)
+        ready = threading.Event()
+        threading.Thread(target=server, args=(self.evt, ready)).start()
+        ready.wait()
 
     def tearDown(self):
         self.evt.wait()