]> granicus.if.org Git - clang/commitdiff
[analyzer] Scan the correct store when finding symbols in a LazyCompoundVal.
authorJordan Rose <jordan_rose@apple.com>
Fri, 15 Feb 2013 00:32:10 +0000 (00:32 +0000)
committerJordan Rose <jordan_rose@apple.com>
Fri, 15 Feb 2013 00:32:10 +0000 (00:32 +0000)
Previously, we were scanning the current store. Now, we properly scan the
store that the LazyCompoundVal came from, which may have very different
live symbols.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@175232 91177308-0d34-0410-b5e6-96231b3b80d8

lib/StaticAnalyzer/Core/ProgramState.cpp

index 73350d88eb627a35894f645d8be63f67ec1c8855..a3db3764fb030687cd8724c6dc7d3563cdb08fad 100644 (file)
@@ -512,8 +512,16 @@ bool ScanReachableSymbols::scan(SVal val) {
   if (loc::MemRegionVal *X = dyn_cast<loc::MemRegionVal>(&val))
     return scan(X->getRegion());
 
-  if (nonloc::LazyCompoundVal *X = dyn_cast<nonloc::LazyCompoundVal>(&val))
-    return scan(X->getRegion());
+  if (nonloc::LazyCompoundVal *X = dyn_cast<nonloc::LazyCompoundVal>(&val)) {
+    StoreManager &StoreMgr = state->getStateManager().getStoreManager();
+    // FIXME: We don't really want to use getBaseRegion() here because pointer
+    // arithmetic doesn't apply, but scanReachableSymbols only accepts base
+    // regions right now.
+    if (!StoreMgr.scanReachableSymbols(X->getStore(),
+                                       X->getRegion()->getBaseRegion(),
+                                       *this))
+      return false;
+  }
 
   if (nonloc::LocAsInteger *X = dyn_cast<nonloc::LocAsInteger>(&val))
     return scan(X->getLoc());