]> granicus.if.org Git - php/commitdiff
libmysql is still 'buggy' - skip test with libmysql
authorUlf Wendel <uw@php.net>
Tue, 20 Oct 2009 14:11:43 +0000 (14:11 +0000)
committerUlf Wendel <uw@php.net>
Tue, 20 Oct 2009 14:11:43 +0000 (14:11 +0000)
ext/mysqli/tests/mysqli_change_user_insert_id.phpt

index 83efb51492352880ed2c35305f652586581877c7..30ea541474afb4697b069961626cbf49ad05e3ec 100644 (file)
@@ -6,13 +6,16 @@ require_once('skipif.inc');
 require_once('skipifemb.inc');
 require_once('skipifconnectfailure.inc');
 require_once('connect.inc');
+
 if (!$IS_MYSQLND) {
        if (!$link = my_mysqli_connect($host, $user, $passwd, $db, $port, $socket))
                die("skip Can't test server version, might hit known bugs http://bugs.mysql.com/bug.php?id=30472, http://bugs.mysql.com/bug.php?id=45184");
-       if (mysqli_get_client_version($link) <= 50135)
-               /* TODO - check wich version got the patch */
+
+       if ((mysqli_get_client_version($link) <= 50139) || (mysqli_get_server_version($link) <= 50139))
+               /* #30472 got fixed in 5.1.23 but #45184 is open */
                die(sprintf("skip libmysql %s should have bugs http://bugs.mysql.com/bug.php?id=30472, http://bugs.mysql.com/bug.php?id=45184",
         mysqli_get_client_version($link)));
+
        mysqli_close($link);
 }
 ?>