Fix returned value, if mysql_stmt_attr_set fails

then mysqli returns true, otherwise false. Wrong logic.

diff --git a/ext/mysqli/mysqli_api.c b/ext/mysqli/mysqli_api.c
index 039a771f91b6362a52634582e0f7c6a6aef9dbc9..2c4e6b9c29ede16ee7f71bd1f8dd6dbdc9b2c586 100644 (file)
--- a/ext/mysqli/mysqli_api.c
+++ b/ext/mysqli/mysqli_api.c
@@ -1848,14 +1848,13 @@ PHP_FUNCTION(mysqli_stmt_attr_set)
        zval    *mysql_stmt;
        ulong   mode;
        ulong   attr;
-       int             rc;
 
        if (zend_parse_method_parameters(ZEND_NUM_ARGS() TSRMLS_CC, getThis(), "Oll", &mysql_stmt, mysqli_stmt_class_entry, &attr, &mode) == FAILURE) {
                return;
        }
        MYSQLI_FETCH_RESOURCE(stmt, MY_STMT *, &mysql_stmt, "mysqli_stmt", MYSQLI_STATUS_VALID);
 
-       if ((rc = mysql_stmt_attr_set(stmt->stmt, attr, (void *)&mode))) {
+       if (FALSE == mysql_stmt_attr_set(stmt->stmt, attr, (void *)&mode)) {
                RETURN_FALSE;
        }
        RETURN_TRUE;