a & b were dereffed above, so they are known to be valid pointers.

z is known to be NULL, nothing to DECREF.

Reported by Klockwork, #107.

diff --git a/Objects/longobject.c b/Objects/longobject.c
index c9b93b6ac63f51adcc524217139d03f6b32fccb2..cbd6f2be593ed713df5b91aede6e4a9263dc1cad 100644 (file)
--- a/Objects/longobject.c
+++ b/Objects/longobject.c
@@ -3149,9 +3149,8 @@ long_bitwise(PyLongObject *a,
                : MAX(size_a, size_b);
        z = _PyLong_New(size_z);
        if (z == NULL) {
-               Py_XDECREF(a);
-               Py_XDECREF(b);
-               Py_XDECREF(z);
+               Py_DECREF(a);
+               Py_DECREF(b);
                return NULL;
        }