Fix handling of OID wraparound while in standalone mode.

If OID wraparound should occur while in standalone mode (unlikely but
possible), we want to advance the counter to FirstNormalObjectId not
FirstBootstrapObjectId.  Otherwise, user objects might be created with OIDs
in the system-reserved range.  That isn't immediately harmful but it poses
a risk of conflicts during future pg_upgrade operations.

Noted by Andres Freund.  Back-patch to all supported branches, since all of
them are supported sources for pg_upgrade operations.

diff --git a/src/backend/access/transam/varsup.c b/src/backend/access/transam/varsup.c
index 555bb134f55ed0d525f7cc65011b7c063c8b8cef..563d4caa9bb61fbe34d2b859a2cd84a511f72758 100644 (file)
--- a/src/backend/access/transam/varsup.c
+++ b/src/backend/access/transam/varsup.c
@@ -449,18 +449,18 @@ GetNewObjectId(void)
         * iterations in GetNewOid.)  Note we are relying on unsigned comparison.
         *
         * During initdb, we start the OID generator at FirstBootstrapObjectId, so
-        * we only enforce wrapping to that point when in bootstrap or standalone
-        * mode.  The first time through this routine after normal postmaster
-        * start, the counter will be forced up to FirstNormalObjectId. This
-        * mechanism leaves the OIDs between FirstBootstrapObjectId and
-        * FirstNormalObjectId available for automatic assignment during initdb,
-        * while ensuring they will never conflict with user-assigned OIDs.
+        * we only wrap if before that point when in bootstrap or standalone mode.
+        * The first time through this routine after normal postmaster start, the
+        * counter will be forced up to FirstNormalObjectId.  This mechanism
+        * leaves the OIDs between FirstBootstrapObjectId and FirstNormalObjectId
+        * available for automatic assignment during initdb, while ensuring they
+        * will never conflict with user-assigned OIDs.
         */
        if (ShmemVariableCache->nextOid < ((Oid) FirstNormalObjectId))
        {
                if (IsPostmasterEnvironment)
                {
-                       /* wraparound in normal environment */
+                       /* wraparound, or first post-initdb assignment, in normal mode */
                        ShmemVariableCache->nextOid = FirstNormalObjectId;
                        ShmemVariableCache->oidCount = 0;
                }
@@ -469,8 +469,8 @@ GetNewObjectId(void)
                        /* we may be bootstrapping, so don't enforce the full range */
                        if (ShmemVariableCache->nextOid < ((Oid) FirstBootstrapObjectId))
                        {
-                               /* wraparound in standalone environment? */
-                               ShmemVariableCache->nextOid = FirstBootstrapObjectId;
+                               /* wraparound in standalone mode (unlikely but possible) */
+                               ShmemVariableCache->nextOid = FirstNormalObjectId;
                                ShmemVariableCache->oidCount = 0;
                        }
                }