]> granicus.if.org Git - python/commitdiff
Merged revisions 86003 via svnmerge from
authorBrian Curtin <brian.curtin@gmail.com>
Sun, 31 Oct 2010 00:08:27 +0000 (00:08 +0000)
committerBrian Curtin <brian.curtin@gmail.com>
Sun, 31 Oct 2010 00:08:27 +0000 (00:08 +0000)
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r86003 | brian.curtin | 2010-10-30 19:03:45 -0500 (Sat, 30 Oct 2010) | 2 lines

  Fix ResourceWarning. Use context manager to properly close file.
........

Lib/test/test_float.py

index 0328d1adc1a05793cb31c031df994ffa70614947..de5ca46fdf67b21462ed6583cbfef8bbb09f310f 100644 (file)
@@ -540,19 +540,20 @@ class IEEEFormatTestCase(unittest.TestCase):
 
     @requires_IEEE_754
     def test_format_testfile(self):
-        for line in open(format_testfile):
-            if line.startswith('--'):
-                continue
-            line = line.strip()
-            if not line:
-                continue
-
-            lhs, rhs = map(str.strip, line.split('->'))
-            fmt, arg = lhs.split()
-            arg = float(arg)
-            self.assertEqual(fmt % arg, rhs)
-            if not math.isnan(arg) and copysign(1.0, arg) > 0.0:
-                self.assertEqual(fmt % -arg, '-' + rhs)
+        with open(format_testfile) as testfile:
+            for line in open(format_testfile):
+                if line.startswith('--'):
+                    continue
+                line = line.strip()
+                if not line:
+                    continue
+
+                lhs, rhs = map(str.strip, line.split('->'))
+                fmt, arg = lhs.split()
+                arg = float(arg)
+                self.assertEqual(fmt % arg, rhs)
+                if not math.isnan(arg) and copysign(1.0, arg) > 0.0:
+                    self.assertEqual(fmt % -arg, '-' + rhs)
 
     def test_issue5864(self):
         self.assertEquals(format(123.456, '.4'), '123.5')