Fixed Issue6312 - httplib fails with HEAD requests to pages with "transfer-encoding...

diff --git a/Doc/library/httplib.rst b/Doc/library/httplib.rst
index 372593380102a814234e69f450e03f6036171e0f..83900875c02d0ce42bc99102ef15011ba78e9806 100644 (file)
--- a/Doc/library/httplib.rst
+++ b/Doc/library/httplib.rst
@@ -560,6 +560,22 @@ Here is an example session that uses the ``GET`` method::
    >>> data2 = r2.read()
    >>> conn.close()
 
+Here is an example session that uses ``HEAD`` method. Note that ``HEAD`` method
+never returns any data. ::
+
+
+   >>> import httplib
+   >>> conn = httplib.HTTPConnection("www.python.org")
+   >>> conn.request("HEAD","/index.html")
+   >>> res = conn.getresponse()
+   >>> print res.status, res.reason
+   200 OK
+   >>> data = res.read()
+   >>> print len(data)
+   0
+   >>> data == ''
+   True
+
 Here is an example session that shows how to ``POST`` requests::
 
    >>> import httplib, urllib

diff --git a/Lib/httplib.py b/Lib/httplib.py
index 43c879790ac05f24bf9d0341e1beca158a86e5e6..5eb3f0d1fa3c8c934e4d70774cee04a6fc4f369d 100644 (file)
--- a/Lib/httplib.py
+++ b/Lib/httplib.py
@@ -524,6 +524,9 @@ class HTTPResponse:
         if self.fp is None:
             return ''
 
+        if self._method == 'HEAD':
+            return ''
+
         if self.chunked:
             return self._read_chunked(amt)
 

diff --git a/Lib/test/test_httplib.py b/Lib/test/test_httplib.py
index 107b904ebc9106f8043adc5d90ea634b642ab3f6..a618c43e9eb70fd247bfb509c0464c67a5b9a2ed 100644 (file)
--- a/Lib/test/test_httplib.py
+++ b/Lib/test/test_httplib.py
@@ -212,6 +212,23 @@ class BasicTest(TestCase):
             finally:
                 resp.close()
 
+    def test_chunked_head(self):
+        chunked_start = (
+            'HTTP/1.1 200 OK\r\n'
+            'Transfer-Encoding: chunked\r\n\r\n'
+            'a\r\n'
+            'hello world\r\n'
+            '1\r\n'
+            'd\r\n'
+        )
+        sock = FakeSocket(chunked_start + '0\r\n')
+        resp = httplib.HTTPResponse(sock, method="HEAD")
+        resp.begin()
+        self.assertEquals(resp.read(), '')
+        self.assertEquals(resp.status, 200)
+        self.assertEquals(resp.reason, 'OK')
+        resp.close()
+
     def test_negative_content_length(self):
         sock = FakeSocket('HTTP/1.1 200 OK\r\n'
                           'Content-Length: -1\r\n\r\nHello\r\n')

diff --git a/Misc/NEWS b/Misc/NEWS
index e38701727b0feb91bcb09e54f2b2968aa8aff15f..1f584f4f4efd38c00295729371abd3cd3f5c6d0c 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -31,6 +31,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #6312: Fixed http HEAD request when the transfer encoding is chunked.
+  It should correctly return an empty response now.
+
 - Issue #7490: to facilitate sharing of doctests between 2.x and 3.x test
   suites, the IGNORE_EXCEPTION_DETAIL directive now also ignores the module
   location of the raised exception. Based on initial patch by Lennart