]> granicus.if.org Git - cgit/commitdiff
ui-atom: fix resource leak: free allocation from cgit_pageurl
authorChristian Hesse <mail@eworm.de>
Sat, 10 Oct 2015 14:56:27 +0000 (16:56 +0200)
committerJason A. Donenfeld <Jason@zx2c4.com>
Sat, 10 Oct 2015 19:40:26 +0000 (21:40 +0200)
Coverity-id: 13945
Signed-off-by: Christian Hesse <mail@eworm.de>
ui-atom.c

index fab4b0fd8d50bbb83b2129227394e65f606f058a..e186299e57c17143f1b3251bd1303ec82a382a21 100644 (file)
--- a/ui-atom.c
+++ b/ui-atom.c
@@ -53,14 +53,17 @@ static void add_entry(struct commit *commit, const char *host)
        cgit_print_date(info->author_date, FMT_ATOMDATE, 0);
        html("</published>\n");
        if (host) {
+               char *pageurl;
                html("<link rel='alternate' type='text/html' href='");
                html(cgit_httpscheme());
                html_attr(host);
-               html_attr(cgit_pageurl(ctx.repo->url, "commit", NULL));
+               pageurl = cgit_pageurl(ctx.repo->url, "commit", NULL);
+               html_attr(pageurl);
                if (ctx.cfg.virtual_root)
                        delim = '?';
                htmlf("%cid=%s", delim, hex);
                html("'/>\n");
+               free(pageurl);
        }
        htmlf("<id>%s</id>\n", hex);
        html("<content type='text'>\n");