This patch fixes the undefined (according to C) and erroneous (under

Digital Uni x with both DEC cc and gcc) behaviour of modifying an
lvalue on the left side an d then using it on the right side of an
assignment. Since this code modifies the
 dbname parameter, it was changing, for example, "dbname=template1"
 into "dbname =emplate1".

David Smith Programmer P

diff --git a/src/interfaces/perl5/Pg.xs b/src/interfaces/perl5/Pg.xs
index 5d8777dae8c2d976daf80248b1495fa8ed7b634b..31df6a250ab36d0e0f4f235695620160ec505f47 100644 (file)
--- a/src/interfaces/perl5/Pg.xs
+++ b/src/interfaces/perl5/Pg.xs
@@ -1,6 +1,6 @@
 /*-------------------------------------------------------
  *
- * $Id: Pg.xs,v 1.9 1998/09/27 19:12:23 mergl Exp $
+ * $Id: Pg.xs,v 1.10 1998/12/13 02:50:20 momjian Exp $
  *
  * Copyright (c) 1997, 1998  Edmund Mergl
  *
@@ -215,7 +215,8 @@ PQconnectdb(conninfo)
                                }
                        } else {
                                while (*ptr && *ptr != ' ' && *ptr != '\t') {
-                                       *ptr++ = tolower(*ptr);
+                                     *ptr = tolower(*ptr);
+                                     ptr++;
                                }
                        }
                }
@@ -732,7 +733,8 @@ connectdb(conninfo)
                                }
                        } else {
                                while (*ptr && *ptr != ' ' && *ptr != '\t') {
-                                       *ptr++ = tolower(*ptr);
+                                       *ptr = tolower(*ptr);
+                                       ptr++;
                                }
                        }
                }