]> granicus.if.org Git - postgresql/commitdiff
Remove broken PGXS code for pg_xlogdump
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 1 Oct 2013 20:36:15 +0000 (17:36 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 1 Oct 2013 20:39:46 +0000 (17:39 -0300)
With the PGXS boilerplate in place, pg_xlogdump currently fails with an
ominous error message that certain targets cannot be built because
certain files do not exist.  Remove that and instead throw a quick error
message alerting the user of the actual problem, which should be easier
to diagnose that the statu quo.

Andres Freund

contrib/pg_xlogdump/Makefile

index 22bd8dc35a2d93bda405e1f0cf0b26d99dc89f7a..ada261c4dd00111ad7d2c7bdc08244302defa3ce 100644 (file)
@@ -13,15 +13,14 @@ RMGRDESCOBJS = $(patsubst %.c,%.o,$(RMGRDESCSOURCES))
 EXTRA_CLEAN = $(RMGRDESCSOURCES) xlogreader.c
 
 ifdef USE_PGXS
-PG_CONFIG = pg_config
-PGXS := $(shell $(PG_CONFIG) --pgxs)
-include $(PGXS)
-else
+$(error "pg_xlogdump cannot be built with PGXS")
+endif
+
 subdir = contrib/pg_xlogdump
 top_builddir = ../..
 include $(top_builddir)/src/Makefile.global
 include $(top_srcdir)/contrib/contrib-global.mk
-endif
+
 
 override CPPFLAGS := -DFRONTEND $(CPPFLAGS)