]> granicus.if.org Git - python/commitdiff
Merged revisions 87895 via svnmerge from
authorBenjamin Peterson <benjamin@python.org>
Wed, 12 Jan 2011 19:29:51 +0000 (19:29 +0000)
committerBenjamin Peterson <benjamin@python.org>
Wed, 12 Jan 2011 19:29:51 +0000 (19:29 +0000)
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r87895 | lukasz.langa | 2011-01-09 12:18:53 -0600 (Sun, 09 Jan 2011) | 5 lines

  #10874: test_urllib2 shouldn't use `is` operator for comparing strings

  Patch by Adreas Stührk.
........

Lib/test/test_urllib2.py

index 94bbc008dd0180bae409879b68b86398d5cc3718..9320e61c4ea211de20478c91266e2289523b7e85 100644 (file)
@@ -758,7 +758,7 @@ class HandlerTests(unittest.TestCase):
             else:
                 self.assertIs(o.req, req)
                 self.assertEqual(req.type, "ftp")
-            self.assertEqual(req.type is "ftp", ftp)
+            self.assertEqual(req.type == "ftp", ftp)
 
     def test_http(self):