]> granicus.if.org Git - llvm/commitdiff
[MC][ELF] Copy top 3 bits of st_other to .symver aliases
authorFangrui Song <maskray@google.com>
Fri, 10 May 2019 17:09:25 +0000 (17:09 +0000)
committerFangrui Song <maskray@google.com>
Fri, 10 May 2019 17:09:25 +0000 (17:09 +0000)
On PowerPC64 ELFv2 ABI, the top 3 bits of st_other encode the local
entry offset. A versioned symbol alias created by .symver should copy
the bits from the source symbol.

This partly fixes PR41048. A full fix needs tracking of .set assignments
and updating st_other fields when finish() is called, see D56586.

Patch by Alfredo Dal'Ava JĂșnior

Differential Revision: https://reviews.llvm.org/D59436

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@360442 91177308-0d34-0410-b5e6-96231b3b80d8

lib/MC/ELFObjectWriter.cpp
test/MC/PowerPC/ppc64-localentry-symver.s [new file with mode: 0644]

index 96bbc2ee630c2904d140e41e09dab19645d173d2..95b0e27452669ea258a3e51d5da0857fa247aad0 100644 (file)
@@ -1279,6 +1279,7 @@ void ELFObjectWriter::executePostLayoutBinding(MCAssembler &Asm,
     // This is the first place we are able to copy this information.
     Alias->setExternal(Symbol.isExternal());
     Alias->setBinding(Symbol.getBinding());
+    Alias->setOther(Symbol.getOther());
 
     if (!Symbol.isUndefined() && !Rest.startswith("@@@"))
       continue;
diff --git a/test/MC/PowerPC/ppc64-localentry-symver.s b/test/MC/PowerPC/ppc64-localentry-symver.s
new file mode 100644 (file)
index 0000000..4c74906
--- /dev/null
@@ -0,0 +1,17 @@
+# RUN: llvm-mc -filetype=obj -triple=powerpc64-unknown-freebsd13.0 %s -o %t
+# RUN: llvm-objdump -t %t | FileCheck %s
+
+# CHECK: 0000000000000000 gw    F .text  00000000 0x60 __impl_foo
+# CHECK: 0000000000000000 g     F .text  00000000 0x60 foo
+# CHECK: 0000000000000000 gw    F .text  00000000 0x60 foo@FBSD_1.1
+
+.globl foo
+.type foo,@function
+foo:
+  nop
+  nop
+  .localentry foo, 8
+
+.symver __impl_foo, foo@FBSD_1.1
+.weak   __impl_foo
+.set    __impl_foo, foo