]> granicus.if.org Git - libvpx/commitdiff
libs.mk, testdata: rm redundant test of LIBVPX_TEST_DATA
authorJames Zern <jzern@google.com>
Wed, 11 Nov 2015 01:54:51 +0000 (17:54 -0800)
committerJames Zern <jzern@google.com>
Wed, 11 Nov 2015 01:54:51 +0000 (17:54 -0800)
the return value of enabled, which may be empty, is handled by the for
loop. this avoids making an unnecessarily long command line which may
fail in certain cases.

Change-Id: Ib88ecbbe2c0f6d7debb600b4caed4884497263b1

libs.mk

diff --git a/libs.mk b/libs.mk
index f28d84a550dfca7d808ffd8b8de93d177e80d298..e6fb068bf76d67cbeabeebea5c4953870560c5b5 100644 (file)
--- a/libs.mk
+++ b/libs.mk
@@ -429,12 +429,10 @@ testdata:: $(LIBVPX_TEST_DATA)
           if [ -n "$${sha1sum}" ]; then\
             set -e;\
             echo "Checking test data:";\
-            if [ -n "$(LIBVPX_TEST_DATA)" ]; then\
-                for f in $(call enabled,LIBVPX_TEST_DATA); do\
-                    grep $$f $(SRC_PATH_BARE)/test/test-data.sha1 |\
-                        (cd $(LIBVPX_TEST_DATA_PATH); $${sha1sum} -c);\
-                done; \
-            fi; \
+            for f in $(call enabled,LIBVPX_TEST_DATA); do\
+                grep $$f $(SRC_PATH_BARE)/test/test-data.sha1 |\
+                    (cd $(LIBVPX_TEST_DATA_PATH); $${sha1sum} -c);\
+            done; \
         else\
             echo "Skipping test data integrity check, sha1sum not found.";\
         fi