LinGui: fix me_method/me_range dependency

umh, esa, tesa -- me_range 4 - 64
dia, hex -- me_range 4 - 16

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@2015 b64f7644-9d1e-0410-96f1-a4d463321fa5

diff --git a/gtk/src/audiohandler.c b/gtk/src/audiohandler.c
index 53c96919bebe88437666e4805de64187485f668b..3c369566b2bf3c516981c0dd2b3c1d22d8a54685 100644 (file)
--- a/gtk/src/audiohandler.c
+++ b/gtk/src/audiohandler.c
@@ -93,8 +93,8 @@ ghb_set_pref_audio(gint titleindex, signal_user_data_t *ud)
        GHashTable *track_indicies;
        gint *iptr;
 
-       GValue *pref_audio;
-       GValue *audio, *acodec, *bitrate, *rate, *mix, *drc;
+       const GValue *pref_audio;
+       const GValue *audio, *acodec, *bitrate, *rate, *mix, *drc;
        gint count, ii, list_count;
        
        g_debug("set_pref_audio");

diff --git a/gtk/src/callbacks.c b/gtk/src/callbacks.c
index b48e1568a9ff441703ce4128e28d609c874422bf..d69992fae1058395630dc108de47ef95304f4fe3 100644 (file)
--- a/gtk/src/callbacks.c
+++ b/gtk/src/callbacks.c
@@ -1368,7 +1368,7 @@ submit_job(GValue *settings)
 {
        static gint unique_id = 1;
        gchar *type, *modified, *preset;
-       GValue *path;
+       const GValue *path;
        gboolean preset_modified;
 
        g_debug("submit_job");
@@ -2184,7 +2184,7 @@ chapter_edited_cb(
                -1);
        gtk_tree_model_get(GTK_TREE_MODEL(store), &iter, 0, &index, -1);
 
-       GValue *chapters;
+       const GValue *chapters;
        GValue *chapter;
 
        chapters = ghb_settings_get_value(ud->settings, "chapter_list");

diff --git a/gtk/src/ghb.ui b/gtk/src/ghb.ui
index e5f59ac975a3af56aede7d1ec2f38f9bbda5180f..978f2a0c118d8b6515ae3a17353d62263f30096a 100644 (file)
--- a/gtk/src/ghb.ui
+++ b/gtk/src/ghb.ui
@@ -2480,7 +2480,7 @@ no-fast-pskip=0:no-dct-decimate=0:cabac=1</property>
                                                 <property name="visible">True</property>
                                                 <property name="events">GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property>
                                                 <property name="tooltip-text" translatable="yes">This sets the shape of the area x264 searches when estimating motion. Your choices are a diamond, a hexagon, a more complex hexagonal shape, or searching the entire frame. You are best off using Uneven Multi-Hexagonal searching.</property>
-                                                <signal handler="x264_widget_changed_cb" name="changed"/>
+                                                <signal handler="x264_me_changed_cb" name="changed"/>
                                               </object>
                                             </child>
                                           </object>

diff --git a/gtk/src/hb-backend.c b/gtk/src/hb-backend.c
index 8579872e4fa52f9ca7a828cf6de117c70bc41fd0..53188820fc0756867c1d69584e51e896ed2b0ead 100644 (file)
--- a/gtk/src/hb-backend.c
+++ b/gtk/src/hb-backend.c
@@ -157,10 +157,11 @@ combo_opts_t direct_opts =
 
 static options_map_t d_me_opts[] =
 {
-       {"Diamond",              "dia", 0, "dia"},
-       {"Hexagon",              "hex", 1, "hex"},
-       {"Uneven Multi-Hexagon", "umh", 2, "umh"},
-       {"Exhaustive",           "esa", 3, "esa"},
+       {"Diamond",              "dia",  0, "dia"},
+       {"Hexagon",              "hex",  1, "hex"},
+       {"Uneven Multi-Hexagon", "umh",  2, "umh"},
+       {"Exhaustive",           "esa",  3, "esa"},
+       {"Hadamard Exhaustive",  "tesa", 4, "tesa"},
 };
 combo_opts_t me_opts =
 {

diff --git a/gtk/src/makedeps.c b/gtk/src/makedeps.c
index b094054e8521318acce0e9e3e2e84098a51e1d7b..1cb5f247984f176a4d58ae8fc4b407f9d1b27e67 100644 (file)
--- a/gtk/src/makedeps.c
+++ b/gtk/src/makedeps.c
@@ -61,7 +61,6 @@ static dependency_t dep_map[] =
        {"x264_bframes", "x264_direct", "0", TRUE},
        {"x264_refs", "x264_mixed_refs", "<2", TRUE},
        {"x264_cabac", "x264_trellis", "TRUE", FALSE},
-       {"x264_me", "x264_merange", "umh|esa", FALSE},
        {"ChapterMarkers", "chapters_list", "TRUE", FALSE},
        {"use_source_name", "chapters_in_destination", "TRUE", FALSE},
 };

diff --git a/gtk/src/queuehandler.c b/gtk/src/queuehandler.c
index f8687b7fb1d9105eb43029e399fafd4844eebad6..adf409e1671fec707f3655192183bc19e18af3b0 100644 (file)
--- a/gtk/src/queuehandler.c
+++ b/gtk/src/queuehandler.c
@@ -392,7 +392,7 @@ audio_list_refresh(signal_user_data_t *ud)
        GtkListStore *store;
        gboolean done;
        gint row = 0;
-       GValue *audio_list;
+       const GValue *audio_list;
 
        g_debug("ghb_audio_list_refresh ()");
        treeview = GTK_TREE_VIEW(GHB_WIDGET(ud->builder, "audio_list"));

diff --git a/gtk/src/resource_data.h b/gtk/src/resource_data.h
index 3b20169fc028506aa438ecb10e22bfaa915c39a5..010d4f00fb3f77502356449291cfec3ef777feef 100644 (file)
--- a/gtk/src/resource_data.h
+++ b/gtk/src/resource_data.h
@@ -4027,7 +4027,7 @@
 "ire frame. You are best off using Uneven Multi-Hexagonal searching.<"
 "/property>\n"
 "                                                <signal handler=&quo"
-"t;x264_widget_changed_cb" name="changed"/>\n"
+"t;x264_me_changed_cb" name="changed"/>\n"
 "                                              </object>\n"
 "                                            </child>\n"
 "                                          </object>\n"
@@ -12570,10 +12570,6 @@
 "              <array>\n"
 "                      <string>x264_trellis</string>\n"
 "              </array>\n"
-"              <key>x264_me</key>\n"
-"              <array>\n"
-"                      <string>x264_merange</string>\n"
-"              </array>\n"
 "              <key>x264_refs</key>\n"
 "              <array>\n"
 "                      <string>x264_mixed_refs</string>\n"
@@ -12913,14 +12909,6 @@
 "                              <true />\n"
 "                      </array>\n"
 "              </array>\n"
-"              <key>x264_merange</key>\n"
-"              <array>\n"
-"                      <array>\n"
-"                              <string>x264_me</string>\n"
-"                              <string>umh|esa</string>\n"
-"                              <false />\n"
-"                      </array>\n"
-"              </array>\n"
 "              <key>x264_mixed_refs</key>\n"
 "              <array>\n"
 "                      <array>\n"

diff --git a/gtk/src/resources.plist b/gtk/src/resources.plist
index ffb34613de407bae8b9bca25cc14c27855820983..7948a3aee6d6fd44026b4cd9e15deb6ba4b49496 100644 (file)
--- a/gtk/src/resources.plist
+++ b/gtk/src/resources.plist
@@ -2485,7 +2485,7 @@ no-fast-pskip=0:no-dct-decimate=0:cabac=1</property>
                                                 <property name="visible">True</property>
                                                 <property name="events">GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property>
                                                 <property name="tooltip-text" translatable="yes">This sets the shape of the area x264 searches when estimating motion. Your choices are a diamond, a hexagon, a more complex hexagonal shape, or searching the entire frame. You are best off using Uneven Multi-Hexagonal searching.</property>
-                                                <signal handler="x264_widget_changed_cb" name="changed"/>
+                                                <signal handler="x264_me_changed_cb" name="changed"/>
                                               </object>
                                             </child>
                                           </object>
@@ -7159,10 +7159,6 @@ R2RrUAAABBgBAQACAAAAQAAAABAAAAAQ////AP///wD///8A////AP///wD///8A////AP///wD///8A
                <array>
                        <string>x264_trellis</string>
                </array>
-               <key>x264_me</key>
-               <array>
-                       <string>x264_merange</string>
-               </array>
                <key>x264_refs</key>
                <array>
                        <string>x264_mixed_refs</string>
@@ -7502,14 +7498,6 @@ R2RrUAAABBgBAQACAAAAQAAAABAAAAAQ////AP///wD///8A////AP///wD///8A////AP///wD///8A
                                <true />
                        </array>
                </array>
-               <key>x264_merange</key>
-               <array>
-                       <array>
-                               <string>x264_me</string>
-                               <string>umh|esa</string>
-                               <false />
-                       </array>
-               </array>
                <key>x264_mixed_refs</key>
                <array>
                        <array>

diff --git a/gtk/src/settings.c b/gtk/src/settings.c
index 03d65c766ea4ca35c3468a302331e623b6958a5b..20c1416a6d24284e09f960efe577f1471af14c3c 100644 (file)
--- a/gtk/src/settings.c
+++ b/gtk/src/settings.c
@@ -98,7 +98,7 @@ ghb_settings_set_boolean(GValue *settings, const gchar *key, gboolean bval)
 }
 
 GValue*
-ghb_settings_get_value(GValue *settings, const gchar *key)
+ghb_settings_get_value(const GValue *settings, const gchar *key)
 {
        GValue *value;
        value = ghb_dict_lookup(settings, key);
@@ -108,7 +108,7 @@ ghb_settings_get_value(GValue *settings, const gchar *key)
 }
 
 gboolean
-ghb_settings_get_boolean(GValue *settings, const gchar *key)
+ghb_settings_get_boolean(const GValue *settings, const gchar *key)
 {
        const GValue* value;
        value = ghb_settings_get_value(settings, key);
@@ -117,7 +117,7 @@ ghb_settings_get_boolean(GValue *settings, const gchar *key)
 }
 
 gint64
-ghb_settings_get_int64(GValue *settings, const gchar *key)
+ghb_settings_get_int64(const GValue *settings, const gchar *key)
 {
        const GValue* value;
        value = ghb_settings_get_value(settings, key);
@@ -126,7 +126,7 @@ ghb_settings_get_int64(GValue *settings, const gchar *key)
 }
 
 gint
-ghb_settings_get_int(GValue *settings, const gchar *key)
+ghb_settings_get_int(const GValue *settings, const gchar *key)
 {
        const GValue* value;
        value = ghb_settings_get_value(settings, key);
@@ -135,7 +135,7 @@ ghb_settings_get_int(GValue *settings, const gchar *key)
 }
 
 gdouble
-ghb_settings_get_double(GValue *settings, const gchar *key)
+ghb_settings_get_double(const GValue *settings, const gchar *key)
 {
        const GValue* value;
        value = ghb_settings_get_value(settings, key);
@@ -144,7 +144,7 @@ ghb_settings_get_double(GValue *settings, const gchar *key)
 }
 
 gchar*
-ghb_settings_get_string(GValue *settings, const gchar *key)
+ghb_settings_get_string(const GValue *settings, const gchar *key)
 {
        const GValue* value;
        value = ghb_settings_get_value(settings, key);
@@ -153,13 +153,13 @@ ghb_settings_get_string(GValue *settings, const gchar *key)
 }
 
 gint
-ghb_settings_combo_int(GValue *settings, const gchar *key)
+ghb_settings_combo_int(const GValue *settings, const gchar *key)
 {
        return ghb_lookup_combo_int(key, ghb_settings_get_value(settings, key));
 }
 
 const gchar*
-ghb_settings_combo_option(GValue *settings, const gchar *key)
+ghb_settings_combo_option(const GValue *settings, const gchar *key)
 {
        return ghb_lookup_combo_option(key, ghb_settings_get_value(settings, key));
 }

diff --git a/gtk/src/settings.h b/gtk/src/settings.h
index 4d6eb22df9133ae64c206dbe8010f5e9b371e7ef..55584ca703cd5523254a8e8e232c04518e247508 100644 (file)
--- a/gtk/src/settings.h
+++ b/gtk/src/settings.h
@@ -77,14 +77,14 @@ void ghb_settings_set_boolean(
        GValue *settings, const gchar *key, gboolean bval);
 void ghb_settings_copy(
        GValue *settings, const gchar *key, const GValue *value);
-GValue* ghb_settings_get_value(GValue *settings, const gchar *key);
-gboolean ghb_settings_get_boolean(GValue *settings, const gchar *key);
-gint64 ghb_settings_get_int64(GValue *settings, const gchar *key);
-gint ghb_settings_get_int(GValue *settings, const gchar *key);
-gdouble ghb_settings_get_double(GValue *settings, const gchar *key);
-gchar* ghb_settings_get_string(GValue *settings, const gchar *key);
-gint ghb_settings_combo_int(GValue *settings, const gchar *key);
-const gchar* ghb_settings_combo_option(GValue *settings, const gchar *key);
+GValue* ghb_settings_get_value(const GValue *settings, const gchar *key);
+gboolean ghb_settings_get_boolean(const GValue *settings, const gchar *key);
+gint64 ghb_settings_get_int64(const GValue *settings, const gchar *key);
+gint ghb_settings_get_int(const GValue *settings, const gchar *key);
+gdouble ghb_settings_get_double(const GValue *settings, const gchar *key);
+gchar* ghb_settings_get_string(const GValue *settings, const gchar *key);
+gint ghb_settings_combo_int(const GValue *settings, const gchar *key);
+const gchar* ghb_settings_combo_option(const GValue *settings, const gchar *key);
 
 GValue* ghb_widget_value(GtkWidget *widget);
 gchar* ghb_widget_string(GtkWidget *widget);

diff --git a/gtk/src/values.c b/gtk/src/values.c
index 94b417f6d39165d47cf5d6846c7447b0f5eb08ec..ad723ee68ba38791eca3e2395d32d34b5d627e6c 100644 (file)
--- a/gtk/src/values.c
+++ b/gtk/src/values.c
@@ -533,7 +533,7 @@ ghb_dict_iter_init(GHashTableIter *iter, GValue *gval)
 }
 
 GValue*
-ghb_dict_lookup(GValue *gval, const gchar *key)
+ghb_dict_lookup(const GValue *gval, const gchar *key)
 {
        GHashTable *dict = g_value_get_boxed(gval);
        return g_hash_table_lookup(dict, key);

diff --git a/gtk/src/values.h b/gtk/src/values.h
index 4000ad6f817dfb6e21f339109e539869ea4aa975..ecf676cdd9ae06c5dd35121e3bf5be573efafac1 100644 (file)
--- a/gtk/src/values.h
+++ b/gtk/src/values.h
@@ -67,7 +67,7 @@ GValue* ghb_rawdata_value_new(ghb_rawdata_t *data);
 
 void ghb_dict_insert(GValue *gval, gchar *key, GValue *val);
 void ghb_dict_iter_init(GHashTableIter *iter, GValue *gval);
-GValue* ghb_dict_lookup(GValue *gval, const gchar *key);
+GValue* ghb_dict_lookup(const GValue *gval, const gchar *key);
 gboolean ghb_dict_remove(GValue *gval, const gchar *key);
 void ghb_register_transforms(void);
 

diff --git a/gtk/src/widget_deps b/gtk/src/widget_deps
index eb9ef27d2a404ce78a4367e945821ea0d86a4abc..092a46a26fcf0f34aafc47db307608d404e792a9 100644 (file)
--- a/gtk/src/widget_deps
+++ b/gtk/src/widget_deps
@@ -100,10 +100,6 @@
        <array>
                <string>x264_trellis</string>
        </array>
-       <key>x264_me</key>
-       <array>
-               <string>x264_merange</string>
-       </array>
        <key>x264_refs</key>
        <array>
                <string>x264_mixed_refs</string>

diff --git a/gtk/src/widget_reverse_deps b/gtk/src/widget_reverse_deps
index fa9c804c4176551efa1a1547a280caf41638816d..ff2da38418fab4847b8dc669e03649646b9cde02 100644 (file)
--- a/gtk/src/widget_reverse_deps
+++ b/gtk/src/widget_reverse_deps
@@ -334,14 +334,6 @@
                        <true />
                </array>
        </array>
-       <key>x264_merange</key>
-       <array>
-               <array>
-                       <string>x264_me</string>
-                       <string>umh|esa</string>
-                       <false />
-               </array>
-       </array>
        <key>x264_mixed_refs</key>
        <array>
                <array>

diff --git a/gtk/src/x264handler.c b/gtk/src/x264handler.c
index 3fbcf49c94f7af4b64d16c270bed64ca72979597..36bed772184e02ec85cc75a093909f4410ce5671 100644 (file)
--- a/gtk/src/x264handler.c
+++ b/gtk/src/x264handler.c
@@ -17,6 +17,7 @@
 #include "values.h"
 #include "callbacks.h"
 #include "presets.h"
+#include "hb-backend.h"
 #include "x264handler.h"
 
 static void x264_opt_update(signal_user_data_t *ud, GtkWidget *widget);
@@ -39,6 +40,36 @@ x264_widget_changed_cb(GtkWidget *widget, signal_user_data_t *ud)
        ghb_clear_presets_selection(ud);
 }
 
+void
+x264_me_changed_cb(GtkWidget *widget, signal_user_data_t *ud)
+{
+       const GValue *gval;
+       gint me;
+
+       ghb_widget_to_setting(ud->settings, widget);
+       if (!ignore_options_update)
+       {
+               ignore_options_update = TRUE;
+               x264_opt_update(ud, widget);
+               ignore_options_update = FALSE;
+       }
+       ghb_check_dependency(ud, widget);
+       ghb_clear_presets_selection(ud);
+       widget = GHB_WIDGET(ud->builder, "x264_merange");
+       gval = ghb_settings_get_value(ud->settings, "x264_me");
+       me = ghb_lookup_combo_int("x264_me", gval);
+       if (me < 2)
+       {       // me < umh
+               // me_range 4 - 16
+               gtk_spin_button_set_range(GTK_SPIN_BUTTON(widget), 4, 16);
+       }
+       else
+       {
+               // me_range 4 - 64
+               gtk_spin_button_set_range(GTK_SPIN_BUTTON(widget), 4, 64);
+       }
+}
+
 void
 x264_entry_changed_cb(GtkWidget *widget, signal_user_data_t *ud)
 {
@@ -581,12 +612,6 @@ sanitize_x264opts(signal_user_data_t *ud, const gchar *options)
        {
                x264_remove_opt(split, x264_bpyramid_syns);
        }
-       gchar *me = ghb_settings_get_string(ud->settings, "x264_me");
-       if (!(strcmp(me, "umh") == 0 || strcmp(me, "esa") == 0))
-       {
-               x264_remove_opt(split, x264_merange_syns);
-       }
-       g_free(me);
        if (!ghb_settings_get_boolean(ud->settings, "x264_cabac"))
        {
                x264_remove_opt(split, x264_trellis_syns);