]> granicus.if.org Git - esp-idf/commitdiff
Fix late argument verification in emac-main
authoralarruskain <alarruskain@users.noreply.github.com>
Mon, 13 Mar 2017 12:31:01 +0000 (13:31 +0100)
committerAngus Gratton <angus@espressif.com>
Wed, 22 Mar 2017 07:12:12 +0000 (15:12 +0800)
Prevent crash when emac_phy_power_enable is not set.

Merges #426 https://github.com/espressif/esp-idf/pull/426

components/ethernet/emac_main.c

index 8c93a1830e476fff5acae0c17ce86618a8e4b435..672ab75dfc0ccf5718c5faa81eebfc6bb9dbde08 100644 (file)
@@ -948,14 +948,14 @@ esp_err_t esp_eth_init(eth_config_t *config)
         emac_set_user_config_data(config);
     }
 
-    emac_config.emac_phy_power_enable(true);    
-
     ret = emac_verify_args();
 
     if (ret != ESP_OK) {
         goto _exit;
     }
 
+    emac_config.emac_phy_power_enable(true);    
+
     //before set emac reg must enable clk
     emac_enable_clk(true);
     REG_SET_FIELD(EMAC_EX_PHYINF_CONF_REG, EMAC_EX_PHY_INTF_SEL, EMAC_EX_PHY_INTF_RMII);