More comments from Chris.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@47210 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/AST/Decl.cpp b/AST/Decl.cpp
index 04d0d3cac2b2536932b7dfd6e870e9e12acaaca7..5d68927b82facc95a3183e1160af79660f57d493 100644 (file)
--- a/AST/Decl.cpp
+++ b/AST/Decl.cpp
@@ -259,18 +259,18 @@ void Decl::addDeclKind(const Kind k) {
 
 // Out-of-line virtual method providing a home for Decl.
 Decl::~Decl() {
-  if (!DeclAttrs)
+  if (!HasAttrs)
     return;
   
   DeclAttrMapTy::iterator it = DeclAttrs->find(this);
-  if (it != DeclAttrs->end()) {
-    delete it->second;
-    DeclAttrs->erase(it);
-    if (DeclAttrs->empty()) {
-      delete DeclAttrs;
-      DeclAttrs = 0;
-    }        
-  }
+  assert(it != DeclAttrs->end() && "No attrs found but HasAttrs is true!");
+
+  delete it->second;
+  DeclAttrs->erase(it);
+  if (DeclAttrs->empty()) {
+    delete DeclAttrs;
+    DeclAttrs = 0;
+  }        
 }
 
 void Decl::addAttr(Attr *newattr)
@@ -278,7 +278,7 @@ void Decl::addAttr(Attr *newattr)
   if (!DeclAttrs)
     DeclAttrs = new llvm::DenseMap<const Decl*, Attr*>;
   
-  Attr *&attr = DeclAttrs->FindAndConstruct(this).second;
+  Attr *&attr = (*DeclAttrs)[this];
 
   newattr->setNext(attr);
   attr = newattr;
@@ -288,10 +288,10 @@ void Decl::addAttr(Attr *newattr)
 
 const Attr *Decl::getAttrs() const
 {
-  if (!HasAttrs || !DeclAttrs)
+  if (!HasAttrs)
     return 0;
   
-  return DeclAttrs->find(this)->second;
+  return (*DeclAttrs)[this];
 }
 
 const char *NamedDecl::getName() const {