]> granicus.if.org Git - icinga2/commitdiff
Always reset Boost beast buffer in HttpServerConnection#ProcessMessages 7476/head
authorMichael Friedrich <michael.friedrich@icinga.com>
Fri, 6 Sep 2019 07:31:16 +0000 (09:31 +0200)
committerMichael Friedrich <michael.friedrich@icinga.com>
Fri, 6 Sep 2019 07:31:16 +0000 (09:31 +0200)
refs #7431

lib/remote/httpserverconnection.cpp

index e2db0641e637a89941849d8b704eb0790f55465a..88a0af5fbba509830e72f339f610b57c6c5dfb75 100644 (file)
@@ -475,6 +475,8 @@ void HttpServerConnection::ProcessMessages(boost::asio::yield_context yc)
 
                        response.set(http::field::server, l_ServerHeader);
 
+                       // Best practice is to always reset the buffer.
+                       buf = {};
                        if (!EnsureValidHeaders(*m_Stream, buf, parser, response, yc)) {
                                break;
                        }
@@ -520,6 +522,8 @@ void HttpServerConnection::ProcessMessages(boost::asio::yield_context yc)
                                break;
                        }
 
+                       // Best practice is to always reset the buffer.
+                       buf = {};
                        if (!EnsureValidBody(*m_Stream, buf, parser, authenticatedUser, response, yc)) {
                                break;
                        }