Fixed elusive caching bug that led to false positives.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@49914 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/clang/Analysis/PathSensitive/GRCoreEngine.h b/include/clang/Analysis/PathSensitive/GRCoreEngine.h
index ccb217ca0aa807a7f560b72c90b7fb9dc7931f7f..61f73093fc1976689fb3657c50bcf1cfbfa5cc04 100644 (file)
--- a/include/clang/Analysis/PathSensitive/GRCoreEngine.h
+++ b/include/clang/Analysis/PathSensitive/GRCoreEngine.h
@@ -164,6 +164,8 @@ public:
   Stmt* getStmt() const { return B[Idx]; }
   
   CFGBlock* getBlock() const { return &B; }
+  
+  bool hasGeneratedNode() const { return HasGeneratedNode; }
 };
   
   
@@ -186,6 +188,8 @@ public:
     CleanedState = getLastNode()->getState();
   }
   
+  bool hasGeneratedNode() const { return NB.hasGeneratedNode(); }
+  
   void setObjCMsgExprAuditors(GRAuditor<StateTy> **B,
                               GRAuditor<StateTy> **E) {
     ObjCMsgExprAuditBeg = B;

diff --git a/lib/Analysis/GRExprEngine.cpp b/lib/Analysis/GRExprEngine.cpp
index 63986fb38a50584117e923b2bfbb03c32a001e88..2e474fc8e9a3d48ebd597dec0492ed3fae0f4789 100644 (file)
--- a/lib/Analysis/GRExprEngine.cpp
+++ b/lib/Analysis/GRExprEngine.cpp
@@ -187,7 +187,8 @@ void GRExprEngine::ProcessStmt(Stmt* S, StmtNodeBuilder& builder) {
   // If no nodes were generated, generate a new node that has all the
   // dead mappings removed.
   
-  if (Dst.size() == 1 && *Dst.begin() == StmtEntryNode)
+  if (Dst.size() == 1 && *Dst.begin() == StmtEntryNode && 
+      !Builder->hasGeneratedNode())
     builder.generateNode(S, GetState(StmtEntryNode), StmtEntryNode);
   
   // NULL out these variables to cleanup.