]> granicus.if.org Git - php/commitdiff
Fix race condition in FPM tests
authorNikita Popov <nikita.ppv@gmail.com>
Thu, 18 Jun 2020 15:01:29 +0000 (17:01 +0200)
committerNikita Popov <nikita.ppv@gmail.com>
Thu, 18 Jun 2020 15:01:29 +0000 (17:01 +0200)
The newly de-XFAILed tests have a race condition. Make sure we
terminate only after expecting all the log lines.

sapi/fpm/tests/log-bwd-multiple-msgs-stdout-stderr.phpt
sapi/fpm/tests/log-bwd-multiple-msgs.phpt

index 376a972bacac06e8ff97215b92dfb52b23d5ca7e..b1b8a65c686e31451af93c52adb4887bcb3576b5 100644 (file)
@@ -34,9 +34,9 @@ $tester->start();
 $tester->expectLogStartNotices();
 $tester->request()->expectEmptyBody();
 $tester->request()->expectEmptyBody();
-$tester->terminate();
 $tester->expectLogLine('msg 1 - ', false);
 $tester->expectLogLine('msg 2 - msg 3', true);
+$tester->terminate();
 $tester->close();
 
 ?>
index b221a8344c8e040f734381911de94b50321ec621..d328aff9db243db54f9e86a9c505f90d7603212e 100644 (file)
@@ -34,9 +34,9 @@ $tester->start();
 $tester->expectLogStartNotices();
 $tester->request()->expectEmptyBody();
 $tester->request()->expectEmptyBody();
-$tester->terminate();
 $tester->expectLogLine('msg 1 - msg 2 - msg 3');
 $tester->expectLogLine('msg 1 - msg 2 - msg 3');
+$tester->terminate();
 $tester->close();
 ?>
 Done