]> granicus.if.org Git - postgresql/commitdiff
Adjust pg_fsync_writethrough so that it will set errno when failing
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 22 Feb 2010 15:26:14 +0000 (15:26 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 22 Feb 2010 15:26:14 +0000 (15:26 +0000)
on a platform that doesn't support this operation.  The former coding
would allow an unrelated errno to be reported, which would be quite
misleading.  Not sure if this has anything to do with the current
buildfarm failures, but it's certainly bogus as-is.

src/backend/storage/file/fd.c

index adea849ab05b9af215ac7e5d019304cb67aa9023..06edf062c1b038445fd89af3820452744848613c 100644 (file)
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.154 2010/02/15 00:50:57 stark Exp $
+ *       $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.155 2010/02/22 15:26:14 tgl Exp $
  *
  * NOTES:
  *
@@ -292,6 +292,7 @@ pg_fsync_writethrough(int fd)
 #elif defined(F_FULLFSYNC)
                return (fcntl(fd, F_FULLFSYNC, 0) == -1) ? -1 : 0;
 #else
+               errno = ENOSYS;
                return -1;
 #endif
        }