]> granicus.if.org Git - sudo/commitdiff
In sudo_edit_create_tfiles(), fix fd leak if sudo_edit_mktemp() fails.
authorTodd C. Miller <Todd.Miller@courtesan.com>
Sat, 7 May 2016 11:10:11 +0000 (05:10 -0600)
committerTodd C. Miller <Todd.Miller@courtesan.com>
Sat, 7 May 2016 11:10:11 +0000 (05:10 -0600)
Coverity CID 104114.

src/sudo_edit.c

index 8679f7e2e64b43582e30b98f0689103c3dc566ed..1661899e4af471aa651aa870844f5eb29ac07f05 100644 (file)
@@ -558,6 +558,8 @@ sudo_edit_create_tfiles(struct command_details *command_details,
            sudo_fatal("seteuid(ROOT_UID)");
        if (tfd == -1) {
            sudo_warn("mkstemps");
+           if (ofd != -1)
+               close(ofd);
            debug_return_int(-1);
        }
        if (ofd != -1) {