Don't use function definitions looking like old-style ones.

This fixes a bunch of somewhat pedantic warnings with new
compilers. Since by far the majority of other functions definitions use
the (void) style it just seems to be consistent to do so as well in the
remaining few places.

diff --git a/contrib/pg_standby/pg_standby.c b/contrib/pg_standby/pg_standby.c
index 861caea348106cfb1f4fb67d2325d27cd8d201fe..5eac2b1e49057409ea2e43c693f99fa951168b12 100644 (file)
--- a/contrib/pg_standby/pg_standby.c
+++ b/contrib/pg_standby/pg_standby.c
@@ -171,7 +171,7 @@ CustomizableInitialize(void)
  *       Is the requested file ready yet?
  */
 static bool
-CustomizableNextWALFileReady()
+CustomizableNextWALFileReady(void)
 {
        if (stat(WALFilePath, &stat_buf) == 0)
        {

diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c
index 177d1e1432e386b7448243d52c9117cfec64f02c..d48d101340ffa48fa23901905420ce131aa73eb1 100644 (file)
--- a/src/backend/access/transam/twophase.c
+++ b/src/backend/access/transam/twophase.c
@@ -295,7 +295,7 @@ AtAbort_Twophase(void)
  * PGXACT entry.
  */
 void
-PostPrepare_Twophase()
+PostPrepare_Twophase(void)
 {
        LWLockAcquire(TwoPhaseStateLock, LW_EXCLUSIVE);
        MyLockedGxact->locking_backend = InvalidBackendId;

diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c
index 31091ba7f3e2f54b4f6dbd91648223f442b99766..d169027689a2aa9c6942565c4c5c7ba87638f164 100644 (file)
--- a/src/backend/commands/trigger.c
+++ b/src/backend/commands/trigger.c
@@ -3226,7 +3226,7 @@ static SetConstraintState SetConstraintStateAddItem(SetConstraintState state,
  * Gets the current query fdw tuplestore and initializes it if necessary
  */
 static Tuplestorestate *
-GetCurrentFDWTuplestore()
+GetCurrentFDWTuplestore(void)
 {
        Tuplestorestate *ret;
 

diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c
index efab4ca0df1af65b5d796b909f7cc646c6b23b7c..a574cf365a379a0e75bef00e1b9eecc8edbfbc55 100644 (file)
--- a/src/backend/replication/logical/snapbuild.c
+++ b/src/backend/replication/logical/snapbuild.c
@@ -610,7 +610,7 @@ SnapBuildExportSnapshot(SnapBuild *builder)
  * owner back to its original value.
  */
 void
-SnapBuildClearExportedSnapshot()
+SnapBuildClearExportedSnapshot(void)
 {
        /* nothing exported, thats the usual case */
        if (!ExportInProgress)

diff --git a/src/backend/replication/repl_scanner.l b/src/backend/replication/repl_scanner.l
index 056cc1412937bb0bc8011464d75b08498155c225..91bac21b06b5607403b086322ed9a52aeb5b5a02 100644 (file)
--- a/src/backend/replication/repl_scanner.l
+++ b/src/backend/replication/repl_scanner.l
@@ -237,7 +237,7 @@ replication_scanner_init(const char *str)
 }
 
 void
-replication_scanner_finish()
+replication_scanner_finish(void)
 {
        yy_delete_buffer(scanbufhandle);
        scanbufhandle = NULL;

diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
index e1bab079d5dbd02fae04b5d209ea51f1b2e5c986..27de156b1ffb7c6d4b7f64bb57a93a4f21428c3a 100644 (file)
--- a/src/backend/replication/walsender.c
+++ b/src/backend/replication/walsender.c
@@ -249,7 +249,7 @@ InitWalSender(void)
  * process, similar to what transaction abort does in a regular backend.
  */
 void
-WalSndErrorCleanup()
+WalSndErrorCleanup(void)
 {
        LWLockReleaseAll();
 

diff --git a/src/backend/storage/ipc/dsm_impl.c b/src/backend/storage/ipc/dsm_impl.c
index 0b10dac72900732df1f3e441c82ff171b76cf47a..921f0292e36cbc8aca31b69c5074a260059b66a0 100644 (file)
--- a/src/backend/storage/ipc/dsm_impl.c
+++ b/src/backend/storage/ipc/dsm_impl.c
@@ -1027,7 +1027,7 @@ dsm_impl_pin_segment(dsm_handle handle, void *impl_private)
 }
 
 static int
-errcode_for_dynamic_shared_memory()
+errcode_for_dynamic_shared_memory(void)
 {
        if (errno == EFBIG || errno == ENOMEM)
                return errcode(ERRCODE_OUT_OF_MEMORY);

diff --git a/src/backend/utils/time/snapmgr.c b/src/backend/utils/time/snapmgr.c
index 2f0e9cda8c323753ca6099ea2322b0f8000eb3ff..074935ce381d2e0f2e8911491cdd6eca3230f455 100644 (file)
--- a/src/backend/utils/time/snapmgr.c
+++ b/src/backend/utils/time/snapmgr.c
@@ -345,7 +345,7 @@ GetNonHistoricCatalogSnapshot(Oid relid)
  * cycles we spent tracking such fine details would be well-spent.
  */
 void
-InvalidateCatalogSnapshot()
+InvalidateCatalogSnapshot(void)
 {
        CatalogSnapshotStale = true;
 }

diff --git a/src/bin/pg_resetxlog/pg_resetxlog.c b/src/bin/pg_resetxlog/pg_resetxlog.c
index 72755b064d51bf17a5bc71a14ff2d6ad172decfa..b771a63317911e3e69c52dab97fb93e623236a7a 100644 (file)
--- a/src/bin/pg_resetxlog/pg_resetxlog.c
+++ b/src/bin/pg_resetxlog/pg_resetxlog.c
@@ -703,7 +703,7 @@ PrintControlValues(bool guessed)
  * Print the values to be changed.
  */
 static void
-PrintNewControlValues()
+PrintNewControlValues(void)
 {
        char            fname[MAXFNAMELEN];
 

diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c
index ae0ba19814fd03d75063495f32a06dae8a6cada5..296d17dbbb3ee592b2974392a03011c99c4e0e59 100644 (file)
--- a/src/pl/plperl/plperl.c
+++ b/src/pl/plperl/plperl.c
@@ -2993,7 +2993,7 @@ plperl_hash_from_tuple(HeapTuple tuple, TupleDesc tupdesc)
 
 
 static void
-check_spi_usage_allowed()
+check_spi_usage_allowed(void)
 {
        /* see comment in plperl_fini() */
        if (plperl_ending)