]> granicus.if.org Git - python/commitdiff
Issue #9512: Made comment more informative.
authorVinay Sajip <vinay_sajip@yahoo.co.uk>
Sun, 22 Aug 2010 18:11:02 +0000 (18:11 +0000)
committerVinay Sajip <vinay_sajip@yahoo.co.uk>
Sun, 22 Aug 2010 18:11:02 +0000 (18:11 +0000)
Lib/logging/handlers.py

index cda84e7010fe55d3cd2ca27091a3312155805898..38beb1079bc551521c4d667c33162f73792ff944 100644 (file)
@@ -108,8 +108,13 @@ class RotatingFileHandler(BaseRotatingHandler):
 
         If maxBytes is zero, rollover never occurs.
         """
+        # If rotation/rollover is wanted, it doesn't make sense to use another
+        # mode. If for example 'w' were specified, then if there were multiple
+        # runs of the calling application, the logs from previous runs would be
+        # lost if the 'w' is respected, because the log file would be truncated
+        # on each run.
         if maxBytes > 0:
-            mode = 'a' # doesn't make sense otherwise!
+            mode = 'a'
         BaseRotatingHandler.__init__(self, filename, mode, encoding, delay)
         self.maxBytes = maxBytes
         self.backupCount = backupCount