]> granicus.if.org Git - python/commitdiff
Fix popen usage.
authorMartin v. Löwis <martin@v.loewis.de>
Thu, 30 Aug 2007 18:14:01 +0000 (18:14 +0000)
committerMartin v. Löwis <martin@v.loewis.de>
Thu, 30 Aug 2007 18:14:01 +0000 (18:14 +0000)
Tools/msi/msilib.py

index 548b640bc31a2aed14cd48d97d835e225a5d805b..ca7e311e252a7e7d2895a3d3b3c17aaef7f83b8a 100644 (file)
@@ -390,8 +390,8 @@ class CAB:
             cabarc = "cabarc.exe"
         cmd = r'"%s" -m lzx:21 n %s.cab @%s.txt' % (cabarc, self.name, self.name)
         p = subprocess.Popen(cmd, shell=True, stdin=subprocess.PIPE,
-                             stdout=subprocess.PIPE, stderr=subprocess.STDOUT)[0]
-        for line in (p.stdout, p.stdin):
+                             stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
+        for line in p.stdout:
             if line.startswith("  -- adding "):
                 sys.stdout.write(".")
             else: