]> granicus.if.org Git - pdns/commitdiff
ixfrdist: Fix a NULL-pointer dereference on a non-existing UID
authorRemi Gacogne <remi.gacogne@powerdns.com>
Tue, 29 May 2018 14:11:04 +0000 (16:11 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Fri, 1 Jun 2018 07:50:20 +0000 (09:50 +0200)
Reported by cppcheck.

pdns/ixfrdist.cc

index 29830a6018a4ebf889e72a626e0aa751e56251a7..4a768ddf4b984f777971578620dc25124e2460e6 100644 (file)
@@ -1037,7 +1037,7 @@ int main(int argc, char** argv) {
     }
 
     g_log<<Logger::Notice<<"Dropping effective user-id to "<<newuid<<endl;
-    if (setuid(pw->pw_uid) < 0) {
+    if (setuid(newuid) < 0) {
       g_log<<Logger::Error<<"Could not set user id to "<<newuid<<": "<<stringerror()<<endl;
       had_error = true;
     }