Comment not freeing mailfrom - found during code review.

diff --git a/src/do_command.c b/src/do_command.c
index 744427ca3eb6d11e4fd8d4344a023ea406aad688..5415e05e1ef7393e1afb09c01f7d26e6b54599fe 100644 (file)
--- a/src/do_command.c
+++ b/src/do_command.c
@@ -372,6 +372,9 @@ static void child_process(entry * e, user * u) {
 
                        /* get sender address.  this is MAILFROM if set (and safe),
                         * root otherwise.
+                        * mailfrom is not freed because it lives only in this short
+                        * child process. Freeing could lead to segfaul, when mailfrom
+                        * is acquired from env_get function.
                         */
                        if (!mailfrom || !*mailfrom || !safe_p(usernm, mailfrom)) {
                                mailfrom = calloc(5, sizeof (char));