]> granicus.if.org Git - python/commitdiff
bpo-29874: fix INCREF for possible NULL values in select_select() (GH-758)
authorXiang Zhang <angwerzx@126.com>
Wed, 22 Mar 2017 04:46:14 +0000 (12:46 +0800)
committerGitHub <noreply@github.com>
Wed, 22 Mar 2017 04:46:14 +0000 (12:46 +0800)
Modules/selectmodule.c

index 6ea308adb018ed2ead7378d7d8a711c1972e7943..da03366bb91602a89fad86338b33790eaeb50821 100644 (file)
@@ -289,9 +289,9 @@ select_select(PyObject *self, PyObject *args)
         else
             ret = PyTuple_Pack(3, ifdlist, ofdlist, efdlist);
 
-        Py_DECREF(ifdlist);
-        Py_DECREF(ofdlist);
-        Py_DECREF(efdlist);
+        Py_XDECREF(ifdlist);
+        Py_XDECREF(ofdlist);
+        Py_XDECREF(efdlist);
     }
 
   finally:
@@ -1298,7 +1298,7 @@ kqueue_event_init(kqueue_event_Object *self, PyObject *args, PyObject *kwds)
 
     if (PyLong_Check(pfd)
 #if IDENT_TYPE == T_UINT
-       && PyLong_AsUnsignedLong(pfd) <= UINT_MAX
+        && PyLong_AsUnsignedLong(pfd) <= UINT_MAX
 #endif
     ) {
         self->e.ident = IDENT_AsType(pfd);