]> granicus.if.org Git - nethack/commitdiff
fix a botl status display issue
authornhmall <nhmall@nethack.org>
Mon, 20 May 2019 03:35:21 +0000 (23:35 -0400)
committernhmall <nhmall@nethack.org>
Mon, 20 May 2019 03:35:21 +0000 (23:35 -0400)
Reported as #H8609 (1679)

Some code recently added to render_status() for BL_CONDITION:
    if (!tty_condition_bits)
        continue;
was short-circuiting the required copy of NOW
values to BEFORE values for later comparison
further down in the for-loop.
    tty_status[BEFORE][idx] = tty_status[NOW][idx];

This caused some fields to be bypassed for rendering
once no more tty_condition_bits were set because the
length comparisons would match.

doc/fixes36.3
win/tty/wintty.c

index 8d5c223768ede4a5bac5b18023cf75126f22c89d..87114389726124bc009223bf0c7fa919d0f5a59e 100644 (file)
@@ -16,6 +16,8 @@ when examining the map with '/' or ';', picking a symbol which is used for
 billing and payment issue as a result of glob coalescing
 glob pricing did not consider weight properly
 glob shop interaction improved to handle more of the expected scenarios
+remove the for-loop short circuit in render_status() that was preventing
+       the copy of BL_CONDITION tty_status values from NOW to BEFORE
 
 
 Fixes to Post-3.6.2 Problems that Were Exposed Via git Repository
index cc191fb65e5e868031434424f16f84abef439a67..831e5326b8207f0cc2ad3d20564ffdb059fe07ac 100644 (file)
@@ -4345,8 +4345,6 @@ render_status(VOID_ARGS)
                      * | Condition Codes |
                      * +-----------------+
                      */
-                    if (!tty_condition_bits)
-                        continue;
                     if (num_rows == 3) {
                         int k;
                         char *dat = &cw->data[y][0];